chore(new-ui): change line height of form item#542
Merged
RafaelVidaurre merged 5 commits intodevelopfrom Apr 2, 2019
Merged
Conversation
Grsmto
reviewed
Mar 22, 2019
Contributor
Grsmto
left a comment
Grsmto
left a comment
There was a problem hiding this comment.
instead of applying the line-height on that element, you should target only the Checkbox component directly. Check packages/new-polymath-ui/src/components/inputs/Checkbox/styles.ts.
Wait for Stan's confirmation but I think we should align this way instead of vertically centered:
RafaelVidaurre
suggested changes
Mar 22, 2019
Contributor
RafaelVidaurre
left a comment
RafaelVidaurre
left a comment
There was a problem hiding this comment.
Marked with Changes Requested so that what @Grsmto suggested is applied
Contributor
|
@sajclarke changes not implemented here yet |
Grsmto
suggested changes
Mar 28, 2019
Contributor
Grsmto
left a comment
Grsmto
left a comment
There was a problem hiding this comment.
This is what I'm seeing on this branch.
Grsmto
approved these changes
Mar 28, 2019
Contributor
|
@sajclarke conflicts here! |
RafaelVidaurre
approved these changes
Apr 2, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please make sure the following boxes are checked before submitting your Pull Request:
This PR:
Fixes:
Need to change the line height for the confirmation notification