fix(new-issuer): step 3 back warning#566
Merged
RafaelVidaurre merged 1 commit intodevelopfrom Apr 3, 2019
Merged
Conversation
Contributor
|
@Grsmto Assigned you as reviewer since I remember you had some comments about this, can you confirm this is good? |
Grsmto
approved these changes
Apr 3, 2019
Contributor
Grsmto
left a comment
There was a problem hiding this comment.
LGTM. However I suppose the isDirty state could have sit in the step 2 directly instead of in the parent. This would have avoid this issue in the first place.
But that's just a comment, not worth refactoring now I think.
Contributor
|
@Grsmto thanks, merging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please make sure the following boxes are checked before submitting your Pull Request:
This PR:
Fixes the issue Issuer warned about changes when going back from step 3