Skip to content

fix(new-issuer): step 3 back warning#566

Merged
RafaelVidaurre merged 1 commit intodevelopfrom
fix/step3-extra-confirm
Apr 3, 2019
Merged

fix(new-issuer): step 3 back warning#566
RafaelVidaurre merged 1 commit intodevelopfrom
fix/step3-extra-confirm

Conversation

@BilalAlGhazi
Copy link
Copy Markdown
Contributor

Please make sure the following boxes are checked before submitting your Pull Request:

  • I've added this PR's link to its Asana task(s)
  • If this PR adds new code that is not going to change in the near future, it includes unit tests to cover it.

This PR:

Fixes the issue Issuer warned about changes when going back from step 3

@RafaelVidaurre RafaelVidaurre requested a review from Grsmto April 2, 2019 20:05
@RafaelVidaurre
Copy link
Copy Markdown
Contributor

@Grsmto Assigned you as reviewer since I remember you had some comments about this, can you confirm this is good?

Copy link
Copy Markdown
Contributor

@Grsmto Grsmto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. However I suppose the isDirty state could have sit in the step 2 directly instead of in the parent. This would have avoid this issue in the first place.
But that's just a comment, not worth refactoring now I think.

@RafaelVidaurre RafaelVidaurre merged commit ef62a7c into develop Apr 3, 2019
@RafaelVidaurre RafaelVidaurre deleted the fix/step3-extra-confirm branch April 3, 2019 18:01
@RafaelVidaurre
Copy link
Copy Markdown
Contributor

@Grsmto thanks, merging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants