Conversation
Contributor
|
@FahdW is this is ready for review? |
Contributor
Author
|
Yeah, go ahead on the review. Design wise it could be a lot better. But for simplicity sake this is what is there atm |
ross-rosario
reviewed
Dec 3, 2019
Contributor
ross-rosario
left a comment
ross-rosario
left a comment
There was a problem hiding this comment.
@FahdW there's a glitsh in navigation. To reproduce:
- Click on "create your ST"
- Then click on "Continue"
- Click on browser's back button to go back to
/accountpage. - The url changes to
/accountbut token creation page remains
| <p> | ||
| <Link to="/ticker"> | ||
| <Button id="create-token-btn" icon="arrow--right"> | ||
| Continue to create your security token |
Contributor
There was a problem hiding this comment.
@FahdW per our most recent changes in develop, the word "Create" should be replaced with "Configure"
| <Link to="/ticker"> | ||
| <Link to="/account"> | ||
| <Button id="create-token-btn" icon="arrow--right"> | ||
| Create your security token |
Contributor
Author
Appears that this glitch is throughout our app. It maybe the way that our router is done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please make sure the following boxes are checked before submitting your Pull Request: