Conversation
Comply with PEP 585
There was no check on pydantic classes, so we can rely on dataclasses instead.
Contributor
|
hummm, but would the following work in this approach: from aion.modalities import LegacySurveyImage
print(LegacySurveyImage.name)i.e. accessing class variables, without instantiating the class? |
Collaborator
Author
Hmm. Just for me to understand. We only instantiate modalities when returned and when we populate the |
Collaborator
Author
Sure we can (see https://docs.python.org/3/library/typing.html#typing.ClassVar). What is the need again? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors several small bits of the
CodecManager.pydanticdependency by the use ofdataclass. (pydanticis great if we actually perform some type checks, and this comes with more complex configuraiton). Standard libarydataclassis perfectly suited for our use case.CodecHFConfig,CodecType,ModalityTypeError, andTokenKeyErrorlru_cacheto cache both access to HF models (note that they are cached by default in the HF library), and codec retrieval from modality