This repository was archived by the owner on Mar 13, 2018. It is now read-only.
Preserve 'extends' when the ShadowDOM polyfill patches document.register - #292
Merged
Conversation
Contributor
There was a problem hiding this comment.
How about:
var p = {prototype: newPrototype};
if (object.extends)
p.extend = object.extends;
Contributor
|
Can you add a test too? |
Before this change this worked well in combination with the custom elements polyfill, however it failed with the native document.register.
Contributor
Author
|
good call - I had not realized that the constructor also had to be fixed (we don't hit that code path in our code). I added tests for both, passes on FF 25, Chrome 30, and Chrome 31 (where we used the polyfill + native document.register) PTAL |
Contributor
|
LGTM |
arv
added a commit
that referenced
this pull request
Nov 4, 2013
Preserve 'extends' when the ShadowDOM polyfill patches document.register
|
Huh ? Why am i mentioned here ? Never contributed to this repo in anyway... |
Contributor
Author
|
@martyglaubitz I think when you did a merge in your clone of here https://github.com/martyglaubitz/bleeding_edge/commit/13b7346dc9cef05c7c2cc81ad7b326eccbeb0198, you included a commit that I made which mentions this pull request. |
syntheticpp
pushed a commit
to syntheticpp/dartruntime
that referenced
this pull request
Nov 26, 2013
and additionally include my pull request from googlearchive/ShadowDOM#292 R=blois@google.com Review URL: https://codereview.chromium.org//54693009 git-svn-id: http://dart.googlecode.com/svn/branches/bleeding_edge/dart@29776 260f80e4-7a28-3924-810f-c04153c831b5
svn2github
pushed a commit
to svn2github/dart-lang
that referenced
this pull request
Jul 15, 2014
and additionally include my pull request from googlearchive/ShadowDOM#292 R=blois@google.com Review URL: https://codereview.chromium.org//54693009 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@29776 260f80e4-7a28-3924-810f-c04153c831b5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed this bug only when using the shadow-dom polyfill in combination with the native document.register. Here is a sample repro example:
You'd expect to see:
b createdandc created, but onlyb createdis printed.