Some element import paths breaks build command

[ergo]

Description

Using latest release I end up with build errors if I import some elements like iron-ajax or paper-tooltip.

Versions & Environment

• Polymer CLI: 0.14.0
• node: v4.4.7
• Operating System: Ubuntu 16.04

Steps to Reproduce

1. Create an application project: polymer init application
2. Add script tag to mainelem-app.html: <link rel="import" href="../../bower_components/iron-ajax/iron-ajax.html">
3. Build: polymer build

Expected Results

No errors are thrown

Actual Results

ergo@ergo-virtual-machine:~/fdgdgdssdg$ polymer build
info:    Building application...
info:    Generating build/unbundled...
info:    Generating build/bundled...
error:   Promise rejection: Error: file path is not in root: /bower_components/promise-polyfill/Promise.js (/home/ergo/fdgdgdssdg)
error:   Error: file path is not in root: /bower_components/promise-polyfill/Promise.js (/home/ergo/fdgdgdssdg)
    at Object.urlFromPath (/home/ergo/BinProgs/node/lib/node_modules/polymer-cli/node_modules/polymer-build/lib/path-transformers.js:41:15)
    at StreamAnalyzer.getFile (/home/ergo/BinProgs/node/lib/node_modules/polymer-cli/node_modules/polymer-build/lib/analyzer.js:107:39)
    at StreamResolver.accept (/home/ergo/BinProgs/node/lib/node_modules/polymer-cli/node_modules/polymer-build/lib/analyzer.js:210:34)
    at FileLoader.request (/home/ergo/BinProgs/node/lib/node_modules/polymer-cli/node_modules/polymer-build/node_modules/hydrolysis/lib/loader/file-loader.js:64:27)
    at Object.<anonymous> (/home/ergo/BinProgs/node/lib/node_modules/polymer-cli/node_modules/polymer-build/node_modules/vulcanize/lib/vulcan.js:318:26)
    at Array.map (native)
    at Object.inlineScripts (/home/ergo/BinProgs/node/lib/node_modules/polymer-cli/node_modules/polymer-build/node_modules/vulcanize/lib/vulcan.js:311:34)
    at Object.<anonymous> (/home/ergo/BinProgs/node/lib/node_modules/polymer-cli/node_modules/polymer-build/node_modules/vulcanize/lib/vulcan.js:458:21)
    at run (/home/ergo/BinProgs/node/lib/node_modules/polymer-cli/node_modules/polymer-build/node_modules/hydrolysis/node_modules/babel-polyfill/node_modules/core-js/modules/es6.promise.js:87:22)
    at /home/ergo/BinProgs/node/lib/node_modules/polymer-cli/node_modules/polymer-build/node_modules/hydrolysis/node_modules/babel-polyfill/node_modules/core-js/modules/es6.promise.js:100:28
error:   Promise rejection: Error: file path is not in root: /bower_components/promise-polyfill/Promise.js (/home/ergo/fdgdgdssdg)
error:   Error: file path is not in root: /bower_components/promise-polyfill/Promise.js (/home/ergo/fdgdgdssdg)
    at Object.urlFromPath (/home/ergo/BinProgs/node/lib/node_modules/polymer-cli/node_modules/polymer-build/lib/path-transformers.js:41:15)
    at StreamAnalyzer.getFile (/home/ergo/BinProgs/node/lib/node_modules/polymer-cli/node_modules/polymer-build/lib/analyzer.js:107:39)
    at StreamResolver.accept (/home/ergo/BinProgs/node/lib/node_modules/polymer-cli/node_modules/polymer-build/lib/analyzer.js:210:34)
    at FileLoader.request (/home/ergo/BinProgs/node/lib/node_modules/polymer-cli/node_modules/polymer-build/node_modules/hydrolysis/lib/loader/file-loader.js:64:27)
    at Object.<anonymous> (/home/ergo/BinProgs/node/lib/node_modules/polymer-cli/node_modules/polymer-build/node_modules/vulcanize/lib/vulcan.js:318:26)
    at Array.map (native)
    at Object.inlineScripts (/home/ergo/BinProgs/node/lib/node_modules/polymer-cli/node_modules/polymer-build/node_modules/vulcanize/lib/vulcan.js:311:34)
    at Object.<anonymous> (/home/ergo/BinProgs/node/lib/node_modules/polymer-cli/node_modules/polymer-build/node_modules/vulcanize/lib/vulcan.js:458:21)
    at run (/home/ergo/BinProgs/node/lib/node_modules/polymer-cli/node_modules/polymer-build/node_modules/hydrolysis/node_modules/babel-polyfill/node_modules/core-js/modules/es6.promise.js:87:22)
    at /home/ergo/BinProgs/node/lib/node_modules/polymer-cli/node_modules/polymer-build/node_modules/hydrolysis/node_modules/babel-polyfill/node_modules/core-js/modules/es6.promise.js:100:28

Same code builds fine for me using 0.13.0

[43081j]

Useful debug output:

accept: /bower_components/polymer/polymer.html
accept: /bower_components/iron-ajax/iron-ajax.html
accept: /bower_components/polymer/polymer-mini.html
accept: /bower_components/iron-ajax/iron-request.html
accept: /bower_components/polymer/polymer-micro.html
accept: /bower_components/promise-polyfill/promise-polyfill-lite.html
accept: /bower_components/promise-polyfill/Promise.js
accept: ../../../../bower_components/promise-polyfill/Promise.js

Clearly this last one, wherever it is coming from, is the problem.

[FredKSchott]

@43081j thanks for posting that! @ergo We've actually seen that before, if you search the github issues for some snippet of that path you might find some help.

At this point this has to be coming from our analyzer, hydrolysis. If you go into /bower_components/promise-polyfill/promise-polyfill-lite.html and comment out the line where it loads ./Promise.js you should see everything build successfully. But when that line is there in any form (Promise.js, ./Promise.js, ../promise-polyfill/Promise.js) we see this added into the output:

accept: /bower_components/promise-polyfill/Promise.js
accept: ../../../../bower_components/promise-polyfill/Promise.js

So it looks like it detects Promise.js successfully, but then also detects a second, bad path immediately after.

[FredKSchott]

We're in the middle of some major refactoring work on the analyzer now, so I'm hopeful we can get this fixed soon. But unfortunately I don't see a simple fix inside of our build logic.

[ergo]

@FredKSchott wouldn't that mean that current 0.14.0 will not work for anyone to build any component that uses iron-ajax?

I'm a bit confused right now about how serious is this issue.

You mentioned:

But unfortunately I don't see a simple fix inside of our build logic.

But wouldn't that mean that most components will not build at all with 0.14.0?

[jay8t6]

+1 - I know you guys are working on it, hopefully it gets fixed soon.

[FredKSchott]

thanks @jay8t6! 😄

@ergo I don't actually know, for example the shop template uses iron-ajax internally but it builds just fine. I've tried tracking it down this morning but haven't been able to find a cause outside of the analyzer, so I'm going to focus my work there in hopes that that fixes this for you.

[ergo]

@FredKSchott Actually it seems I was wrong 0.13.0 also fails - but does that silently - no error output is present.

I've prepared a minimal test case for you here:
https://github.com/ergo/polymer-build-test
Does that help?

[43081j]

@FredKSchott i had a look at this earlier.

hydrolysis inlines any script tags it finds (as long as they are outside any templates), here.

vulcanize also inlines the exact same script tags after having hydrolysis analyze it, here.

This vulcanize one is the one which fails because ../wherever does not begin with the root.

Maybe this helps point you in the right direction. Could be a difference in how they each resolve paths or something :)

[JGSolutions]

Not sure if this is the same issue but when i do polymer build or polymer serve i get these errors:

error: Uncaught exception: TypeError: Cannot read property 'catch' of undefined error: TypeError: Cannot read property 'catch' of undefined at /usr/local/lib/node_modules/polymer-cli/bin/polymer.js:32:12 at /usr/local/lib/node_modules/polymer-cli/node_modules/resolve/lib/async.js:44:21 at ondir (/usr/local/lib/node_modules/polymer-cli/node_modules/resolve/lib/async.js:187:31) at /usr/local/lib/node_modules/polymer-cli/node_modules/resolve/lib/async.js:153:39 at onex (/usr/local/lib/node_modules/polymer-cli/node_modules/resolve/lib/async.js:93:22) at /usr/local/lib/node_modules/polymer-cli/node_modules/resolve/lib/async.js:24:18 at FSReqWrap.oncomplete (fs.js:82:15)

@FredKSchott similar issues as @ergo ?

[JGSolutions]

actually in the gitlab CI i get this error:

{ err: { message: 'SyntaxError: Unexpected token: punc ())', filename: 0, line: 54, col: 77, pos: 1151, stack: 'Error\n at new JS_Parse_Error (eval at <anonymous> (/usr/local/lib/node_modules/polymer-cli/node_modules/uglify-js/tools/node.js:28:1), <anonymous>:1545:18)\n at js_error (eval at <anonymous> (/usr/local/lib/node_modules/polymer-cli/node_modules/uglify-js/tools/node.js:28:1), <anonymous>:1553:11)\n at croak (eval at <anonymous> (/usr/local/lib/node_modules/polymer-cli/node_modules/uglify-js/tools/node.js:28:1), <anonymous>:2092:9)\n at token_error (eval at <anonymous> (/usr/local/lib/node_modules/polymer-cli/node_modules/uglify-js/tools/node.js:28:1), <anonymous>:2100:9)\n at unexpected (eval at <anonymous> (/usr/local/lib/node_modules/polymer-cli/node_modules/uglify-js/tools/node.js:28:1), <anonymous>:2106:9)\n at expr_atom (eval at <anonymous> (/usr/local/lib/node_modules/polymer-cli/node_modules/uglify-js/tools/node.js:28:1), <anonymous>:2621:13)\n at maybe_unary (eval at <anonymous> (/usr/local/lib/node_modules/polymer-cli/node_modules/uglify-js/tools/node.js:28:1), <anonymous>:2795:19)\n at expr_ops (eval at <anonymous> (/usr/local/lib/node_modules/polymer-cli/node_modules/uglify-js/tools/node.js:28:1), <anonymous>:2830:24)\n at maybe_conditional (eval at <anonymous> (/usr/local/lib/node_modules/polymer-cli/node_modules/uglify-js/tools/node.js:28:1), <anonymous>:2835:20)\n at maybe_assign (eval at <anonymous> (/usr/local/lib/node_modules/polymer-cli/node_modules/uglify-js/tools/node.js:28:1), <anonymous>:2859:20)' } }

[ergo]

@FredKSchott If this helps a bit I've found something interesting, (in my test example).

if i change:

<link rel="import" href="/src/build-test-app/build-test-app.html">

to:

<link rel="import" href="src/build-test-app/build-test-app.html">

Making it a relative path the build command finishes successfully and iron-ajax is inline in the resulting file.

[jay8t6]

I see that a new version is out... has the fix been included in it?

[FredKSchott]

@jay8t6 you could try but I don't think so, the new release was mostly init / starter-kit focused.
@JGSolutions oof, that's a different kind of error. Can you open up a new issue with reproduction steps so that we can work on a fix?
@ergo where do you make that change? That's great to hear that it worked, but if you made it in index.html then that will break your app if it is served from any URL that isn't the site root.

If anyone affected is willing to dig into the code base to fix this issue, I'm sure it would be greatly appreciated by everyone! I don't have the resources to dig further into this issue until the new analyzer is complete, but I'd be happy to answer questions and help guide anyone who can tackle it themselves.

[JGSolutions]

@FredKSchott I will open up an issue for the first error I posted. But for the second error which I was getting on the gitlab CI build process it was an issue with my code using ES6 syntax which is fine now.