This repository was archived by the owner on Dec 7, 2021. It is now read-only.
add new polymer 2.0 element and application templates#554
Merged
FredKSchott merged 3 commits intomasterfrom Feb 4, 2017
Merged
add new polymer 2.0 element and application templates#554FredKSchott merged 3 commits intomasterfrom
FredKSchott merged 3 commits intomasterfrom
Conversation
justinfagnani
approved these changes
Feb 3, 2017
|
|
||
| export class ApplicationGenerator extends Generator { | ||
| props: any; | ||
| export function createApplicationGenerator(templateName: string): |
Contributor
There was a problem hiding this comment.
doc that the template name is both the display name and where the template files are loaded from
|
|
||
| export class ElementGenerator extends Generator { | ||
| props: any; | ||
| export function createElementGenerator(templateName: string): |
Contributor
Author
|
Comments addressed, letting CI run and then will merge after |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The diff is bigger than it looks, there are a lot of files moved around and created to add the two new Yeoman templates. You can find most changes in
src/init/init.ts.