Merged
Conversation
In preparation for deleting it there, now that this is the canonical repo for it.
Moved from https://github.com/polymer/vscode-plugin Once this is released we'll migrate the other plugins to use this rather than our home-grown protocol, and deprecate then remove the editor server.
Check in clang-format config. Format source.
* Get the language server compiling cleanly. Seems like the vscode languageserver typedefs just became null-aware, causing some mild breakage. * Fix type error in getReferencesForFeatureAtPosition
Add slots to autocompletion of snippets * Modify quicktest npm command to ignore compiler warnings when using npm link
warn() doesn't seem to.
|
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
justinfagnani
approved these changes
Apr 11, 2018
aomarks
added a commit
that referenced
this pull request
Jul 9, 2018
Previously we were using url.parse and assuming the path would be a valid file path. However this will not 1) unescape percent-encoded characters 2) remove the leading slash before Windows drive letters. The vscode-uri library does this correctly.
This was referenced Nov 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.