fix(dialog): drop dead /api/open-file call from dialog markdown#4
Merged
PolyphonyRequiem merged 1 commit intofeat/agent-dialog-mode-cleanfrom May 4, 2026
Merged
Conversation
The DialogDetail component intercepted relative-file links in agent markdown and POSTed to /api/open-file, but that endpoint was meant to land in microsoft#114 (closed). Clicks silently 404 and leave users staring at links that look interactive but do nothing. Drop the link rewriting (and the now-unused isRelativeFileLink guard) and render every link as a plain anchor with target=_blank + rel=noopener. External URLs still open in a new tab; relative paths become honest broken links instead of fake interactive ones. If/when the file-open endpoint comes back in a future PR, the rewriting can return alongside the matching server-side validation. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses microsoft#130 (comment) —
/api/open-filewas supposed to land in microsoft#114, but microsoft#114 is closed, so the click handler inDialogDetailsilently 404s.Going with option 2 from the original review: drop the link rewriting and the (now-unused)
isRelativeFileLinkguard, render every link as a plain anchor withtarget=_blank+rel=noopener. External URLs still open in a new tab; relative paths become honest broken links instead of fake interactive ones.If/when the file-open endpoint comes back in a future PR, the rewriting can return alongside the matching server-side validation (path traversal, symlink resolution, containment check).
Static bundle rebuilt with vite. Pre-existing TS errors on the branch are unchanged.