Skip to content

Conversation

@miratepuffin
Copy link
Collaborator

@miratepuffin miratepuffin commented Mar 5, 2025

What changes were proposed in this pull request?

  • Added a new namespace API in graphql which allows you to easily explore the graphs which are present within each path, and explode the childen and parent of each namespace. This will replace the GQLgraphs api which will be deprecated.

Why are the changes needed?

  • Pain to currently work out where everything in as you can only query either one graph or all of them so you to do a lot of post processing.

Does this PR introduce any user-facing change? If yes is this documented?

  • Yes and to do

How was this patch tested?

  • Several new tests on path vailidity making sure users cannot escape the working directory.

Are there any further changes required?

  • GqlGraphs needs to be removed

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Rust Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: 43f1f68 Previous: 0d81c86 Ratio
lotr_graph/has_node_existing 32 ns/iter (± 2) 13 ns/iter (± 0) 2.46

This comment was automatically generated by workflow using github-action-benchmark.

Copy link
Collaborator

@ljeub-pometry ljeub-pometry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor things to tidy up.
Handling of \ in paths looks like it could give wrong results

@CLAassistant
Copy link

CLAassistant commented Mar 24, 2025

CLA assistant check
All committers have signed the CLA.

@ljeub-pometry ljeub-pometry merged commit 87c6d93 into master Mar 31, 2025
20 checks passed
@ljeub-pometry ljeub-pometry deleted the graphql-ls branch March 31, 2025 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants