Merged
Conversation
* impl bool filters, add tests * fix imports * add review suggestions * add more tests * add gql tests * more tests * fix test * add more review suggestions * add more review suggestions * add delete_edge for py graph, add tests, add review suggestions * fix tests * chore: apply tidy-public auto-fixes --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* merge clis and configs * commit missing main file * fix compilation errors and python imports * cli actually working * add server subcommand * add help messages and version option * fix compilation errors * add AppConfigBuilder import back * simplify the deadlock tests * revert ui-test commit * switch to parking_lot for deadlock tests * clear up the main.rs in raphtory-graphql * chore: apply tidy-public auto-fixes --------- Co-authored-by: Fabian Murariu <2404621+fabianmurariu@users.noreply.github.com> Co-authored-by: Fabian Murariu <murariu.fabian@gmail.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Rust Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.
| Benchmark suite | Current: 7734e08 | Previous: 233ef2c | Ratio |
|---|---|---|---|
lotr_graph/num_edges |
5 ns/iter (± 0) |
0 ns/iter (± 0) |
+∞ |
lotr_graph/num_nodes |
397 ns/iter (± 1) |
1 ns/iter (± 0) |
397 |
lotr_graph/graph_latest |
3 ns/iter (± 0) |
0 ns/iter (± 0) |
+∞ |
lotr_graph_materialise/materialize |
9360039 ns/iter (± 63094) |
1488686 ns/iter (± 6933) |
6.29 |
lotr_graph_window_100/num_edges |
30 ns/iter (± 0) |
9 ns/iter (± 0) |
3.33 |
lotr_graph_window_100/num_nodes |
405 ns/iter (± 2) |
5 ns/iter (± 0) |
81 |
lotr_graph_window_100_materialise/materialize |
9567664 ns/iter (± 81822) |
1627599 ns/iter (± 4656) |
5.88 |
lotr_graph_window_10/has_node_existing |
129 ns/iter (± 9) |
61 ns/iter (± 11) |
2.11 |
lotr_graph_window_10/iterate nodes |
34418 ns/iter (± 757) |
10304 ns/iter (± 15) |
3.34 |
lotr_graph_window_10/iterate edges |
103266 ns/iter (± 214) |
44150 ns/iter (± 234) |
2.34 |
lotr_graph_window_10_materialise/materialize |
6140808 ns/iter (± 119966) |
998860 ns/iter (± 2415) |
6.15 |
lotr_graph_subgraph_10pc/has_edge_existing |
570 ns/iter (± 3) |
88 ns/iter (± 0) |
6.48 |
lotr_graph_subgraph_10pc/num_nodes |
316 ns/iter (± 8) |
4 ns/iter (± 0) |
79 |
lotr_graph_subgraph_10pc/has_node_existing |
243 ns/iter (± 3) |
34 ns/iter (± 0) |
7.15 |
lotr_graph_subgraph_10pc/iterate nodes |
4950 ns/iter (± 6) |
863 ns/iter (± 16) |
5.74 |
lotr_graph_subgraph_10pc_windowed/has_node_existing |
128 ns/iter (± 9) |
61 ns/iter (± 13) |
2.10 |
lotr_graph_subgraph_10pc_windowed/iterate nodes |
4322 ns/iter (± 9) |
1383 ns/iter (± 12) |
3.13 |
lotr_graph_window_50_layered/num_edges |
80069 ns/iter (± 1576) |
39598 ns/iter (± 840) |
2.02 |
lotr_graph_window_50_layered/num_nodes |
106216 ns/iter (± 2313) |
22306 ns/iter (± 300) |
4.76 |
lotr_graph_window_50_layered/has_node_existing |
1349 ns/iter (± 206) |
125 ns/iter (± 15) |
10.79 |
lotr_graph_window_50_layered/max_id |
117934 ns/iter (± 6704) |
27795 ns/iter (± 407) |
4.24 |
lotr_graph_window_50_layered/max_degree |
1973765 ns/iter (± 20475) |
293043 ns/iter (± 10169) |
6.74 |
lotr_graph_window_50_layered/iterate nodes |
239608 ns/iter (± 1219) |
17134 ns/iter (± 63) |
13.98 |
lotr_graph_window_50_layered/iterate edges |
220311 ns/iter (± 512) |
83373 ns/iter (± 1849) |
2.64 |
lotr_graph_window_50_layered/max_neighbour_degree |
3710146 ns/iter (± 32108) |
383051 ns/iter (± 2002) |
9.69 |
lotr_graph_window_50_layered/graph_latest |
185833 ns/iter (± 3407) |
37869 ns/iter (± 1442) |
4.91 |
lotr_graph_window_50_layered_materialise/materialize |
20159117 ns/iter (± 317477) |
3418684 ns/iter (± 20401) |
5.90 |
lotr_graph_persistent_window_50_layered/num_edges_temporal |
585968 ns/iter (± 17932) |
204253 ns/iter (± 3741) |
2.87 |
lotr_graph_persistent_window_50_layered/num_nodes |
138626 ns/iter (± 2478) |
32897 ns/iter (± 3115) |
4.21 |
lotr_graph_persistent_window_50_layered/has_node_existing |
1940 ns/iter (± 447) |
175 ns/iter (± 98) |
11.09 |
lotr_graph_persistent_window_50_layered/max_id |
154537 ns/iter (± 2650) |
40512 ns/iter (± 694) |
3.81 |
lotr_graph_persistent_window_50_layered/max_degree |
2763855 ns/iter (± 17982) |
460333 ns/iter (± 7973) |
6.00 |
lotr_graph_persistent_window_50_layered/iterate nodes |
328584 ns/iter (± 4540) |
37462 ns/iter (± 198) |
8.77 |
lotr_graph_persistent_window_50_layered/iterate edges |
184013 ns/iter (± 861) |
89880 ns/iter (± 573) |
2.05 |
lotr_graph_persistent_window_50_layered/max_neighbour_degree |
4933817 ns/iter (± 14091) |
510569 ns/iter (± 7913) |
9.66 |
lotr_graph_persistent_window_50_layered/graph_latest |
277556 ns/iter (± 3239) |
60151 ns/iter (± 1039) |
4.61 |
lotr_graph_persistent_window_50_layered_materialise/materialize |
48678066 ns/iter (± 1320753) |
5156308 ns/iter (± 111612) |
9.44 |
lotr_graph/proto_decode |
9716326 ns/iter (± 71231) |
1915847 ns/iter (± 23669) |
5.07 |
lotr_graph/proto_encode |
9253701 ns/iter (± 63016) |
1211819 ns/iter (± 90658) |
7.64 |
This comment was automatically generated by workflow using github-action-benchmark.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Why are the changes needed?
Does this PR introduce any user-facing change? If yes is this documented?
How was this patch tested?
Are there any further changes required?