Move deletion flag to edge id#2600
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Rust Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.
| Benchmark suite | Current: 30a09f6 | Previous: 9823ef7 | Ratio |
|---|---|---|---|
lotr_graph/num_edges |
4 ns/iter (± 0) |
0 ns/iter (± 0) |
+∞ |
lotr_graph/num_nodes |
4 ns/iter (± 0) |
1 ns/iter (± 0) |
4 |
lotr_graph/has_node_nonexisting |
5 ns/iter (± 0) |
2 ns/iter (± 0) |
2.50 |
lotr_graph/iterate_exploded_edges |
619695 ns/iter (± 25222) |
285473 ns/iter (± 2920) |
2.17 |
lotr_graph/graph_latest |
3 ns/iter (± 0) |
0 ns/iter (± 0) |
+∞ |
lotr_graph_materialise/materialize |
7871294 ns/iter (± 19599) |
1564816 ns/iter (± 35303) |
5.03 |
lotr_graph_window_100/num_nodes |
14 ns/iter (± 0) |
5 ns/iter (± 0) |
2.80 |
lotr_graph_window_100/iterate_exploded_edges |
866799 ns/iter (± 2732) |
325242 ns/iter (± 847) |
2.67 |
lotr_graph_window_100_materialise/materialize |
8359010 ns/iter (± 45179) |
1669150 ns/iter (± 10700) |
5.01 |
lotr_graph_window_10/has_node_existing |
154 ns/iter (± 11) |
62 ns/iter (± 11) |
2.48 |
lotr_graph_window_10/iterate nodes |
35285 ns/iter (± 94) |
11339 ns/iter (± 40) |
3.11 |
lotr_graph_window_10/iterate edges |
103894 ns/iter (± 197) |
48684 ns/iter (± 211) |
2.13 |
lotr_graph_window_10/iterate_exploded_edges |
411181 ns/iter (± 1023) |
155788 ns/iter (± 1001) |
2.64 |
lotr_graph_window_10_materialise/materialize |
3675946 ns/iter (± 25648) |
971980 ns/iter (± 4278) |
3.78 |
lotr_graph_subgraph_10pc/has_node_nonexisting |
5 ns/iter (± 0) |
2 ns/iter (± 0) |
2.50 |
lotr_graph_subgraph_10pc_materialise/materialize |
1665478 ns/iter (± 28020) |
334634 ns/iter (± 1287) |
4.98 |
lotr_graph_subgraph_10pc_windowed/has_node_existing |
160 ns/iter (± 9) |
62 ns/iter (± 14) |
2.58 |
lotr_graph_subgraph_10pc_windowed/iterate nodes |
5612 ns/iter (± 123) |
1365 ns/iter (± 3) |
4.11 |
lotr_graph_subgraph_10pc_windowed_materialise/materialize |
1021689 ns/iter (± 12702) |
230399 ns/iter (± 2617) |
4.43 |
lotr_graph_window_50_layered/num_edges |
78424 ns/iter (± 888) |
38714 ns/iter (± 1017) |
2.03 |
lotr_graph_window_50_layered/num_edges_temporal |
163286 ns/iter (± 3268) |
70121 ns/iter (± 7586) |
2.33 |
lotr_graph_window_50_layered/has_node_existing |
473 ns/iter (± 22) |
129 ns/iter (± 12) |
3.67 |
lotr_graph_window_50_layered/has_node_nonexisting |
5 ns/iter (± 0) |
2 ns/iter (± 0) |
2.50 |
lotr_graph_window_50_layered/iterate nodes |
82816 ns/iter (± 196) |
19308 ns/iter (± 47) |
4.29 |
lotr_graph_window_50_layered/iterate edges |
215251 ns/iter (± 610) |
83616 ns/iter (± 1318) |
2.57 |
lotr_graph_window_50_layered/graph_latest |
82422 ns/iter (± 1168) |
36649 ns/iter (± 916) |
2.25 |
lotr_graph_window_50_layered_materialise/materialize |
34027696 ns/iter (± 229134) |
3488825 ns/iter (± 24948) |
9.75 |
lotr_graph_persistent_window_50_layered/num_edges_temporal |
671244 ns/iter (± 6371) |
192686 ns/iter (± 1569) |
3.48 |
lotr_graph_persistent_window_50_layered/has_node_existing |
507 ns/iter (± 383) |
174 ns/iter (± 83) |
2.91 |
lotr_graph_persistent_window_50_layered/has_node_nonexisting |
5 ns/iter (± 0) |
2 ns/iter (± 0) |
2.50 |
lotr_graph_persistent_window_50_layered/iterate nodes |
110443 ns/iter (± 161) |
35886 ns/iter (± 191) |
3.08 |
lotr_graph_persistent_window_50_layered/iterate edges |
190602 ns/iter (± 562) |
84161 ns/iter (± 596) |
2.26 |
lotr_graph_persistent_window_50_layered/iterate_exploded_edges |
4800183 ns/iter (± 15483) |
1659940 ns/iter (± 19402) |
2.89 |
lotr_graph_persistent_window_50_layered/graph_latest |
119369 ns/iter (± 1133) |
57549 ns/iter (± 4809) |
2.07 |
lotr_graph_persistent_window_50_layered_materialise/materialize |
60320476 ns/iter (± 75002) |
5298035 ns/iter (± 147912) |
11.39 |
lotr_graph/proto_encode |
9547439 ns/iter (± 38425) |
1157897 ns/iter (± 73709) |
8.25 |
This comment was automatically generated by workflow using github-action-benchmark.
da10816 to
caf6e5f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Move deletion flag to the edge id to make it easier to handle when writing to disk
Why are the changes needed?
Does this PR introduce any user-facing change? If yes is this documented?
How was this patch tested?
Are there any further changes required?