configure.in: cause a reasonable diagnostic if AX_CHECK_COMPILE_FLAG is not available#1056
Merged
RossBencina merged 2 commits intoAug 14, 2025
Conversation
This was referenced Aug 8, 2025
philburk
reviewed
Aug 14, 2025
| AC_PREREQ(2.13) | ||
|
|
||
| dnl cause a reasonable diagnostic if AX_CHECK_COMPILE_FLAG is not available | ||
| m4_pattern_forbid([AX_CHECK_COMPILE_FLAG])dnl |
Collaborator
There was a problem hiding this comment.
The "dnl" at the end seems unnecessary.
RossBencina
commented
Aug 14, 2025
philburk
approved these changes
Aug 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On some platforms the
AX_CHECK_COMPILE_FLAGmacro (used in ourconfigure.in) is not defined within the baseautotoolspackage, but rather in a separateautotools-archivepackage. If that package is not installedAX_CHECK_COMPILE_FLAGis not defined. This results in the use ofAX_CHECK_COMPILE_FLAGbeing emitted verbatim into./configure, which in turn results in a cryptic error message:This patch improves the error diagnostic. The new diagnostic will be emitted at the time that
autoreconfis run, and will not allow the./configurefile to be generated if theAX_CHECK_COMPILE_FLAGmacro is not defined. The new error is: