Skip to content

dev#186

Merged
RambokDev merged 69 commits into
mainfrom
dev
Mar 6, 2026
Merged

dev#186
RambokDev merged 69 commits into
mainfrom
dev

Conversation

@RambokDev
Copy link
Copy Markdown
Collaborator

@RambokDev RambokDev commented Mar 6, 2026

Summary by CodeRabbit

  • Chores
    • Enhanced secret management by consolidating authentication credentials into centralized secret storage.
    • Restructured release workflow to separate job responsibilities and improve process organization.
    • Improved notification flow for release events with updated dependency management.

charlesgauthereau added 30 commits March 6, 2026 09:10
# Conflicts:
#	.github/workflows/auto-release.yml
# Conflicts:
#	.github/workflows/auto-release.yml
# Conflicts:
#	.github/workflows/auto-release.yml
# Conflicts:
#	.github/workflows/auto-release.yml
# Conflicts:
#	.github/workflows/auto-release.yml
# Conflicts:
#	.github/workflows/auto-release.yml
# Conflicts:
#	.github/workflows/auto-release.yml
# Conflicts:
#	.github/workflows/auto-release.yml
# Conflicts:
#	.github/workflows/auto-release.yml
# Conflicts:
#	.github/workflows/auto-release.yml
charlesgauthereau added 26 commits March 6, 2026 13:05
# Conflicts:
#	.github/workflows/release.yml
# Conflicts:
#	.github/workflows/release.yml
# Conflicts:
#	.github/workflows/release.yml
# Conflicts:
#	.github/workflows/release.yml
# Conflicts:
#	.github/workflows/release.yml
# Conflicts:
#	.github/workflows/release.yml
# Conflicts:
#	.github/workflows/release.yml
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Mar 6, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: b5d8e56b-f298-4726-a127-821eb2897a07

📥 Commits

Reviewing files that changed from the base of the PR and between 01b7a58 and aa736b8.

📒 Files selected for processing (2)
  • .github/workflows/discord.yml
  • .github/workflows/release.yml

📝 Walkthrough

Walkthrough

GitHub Actions workflows are refactored to restructure release and notification jobs. The release job is renamed to create-release, a new finalize-release job is introduced with dependencies, and notification flow is reorganized to use job outputs instead of step outputs. Discord webhook configuration switches from workflow inputs to secrets.

Changes

Cohort / File(s) Summary
Discord Webhook Configuration
.github/workflows/discord.yml
Replaces workflow_call inputs for discord_webhook and gh_token with secret references (secrets.DISCORD_WEBHOOK and secrets.GH_TOKEN); environment variables now sourced from secrets instead of inputs.
Release Workflow Job Restructuring
.github/workflows/release.yml
Renames release job to create-release; introduces finalize-release job as downstream dependency; reorganizes Discord notification into separate notify-discord job that consumes draft_tag output from create-release; updates all downstream references to use needs.create-release.outputs.draft_tag; switches Discord notification to use secret references for DISCORD_WEBHOOK and GH_TOKEN; moves Docker publish steps to commented placeholders.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

  • dev #175: Modifies release workflow and switches Discord/GH token usage to secrets, mirroring the configuration changes in this PR.
  • dev #177: Updates draft_tag handling and references in release.yml, directly related to the output restructuring changes.
  • dev #179: Modifies release workflow job organization and Discord notification flow with similar structural changes.

Poem

🐰 The workflows hop and dance,
Jobs now organized with care,
Secrets whisper instead of shout,
Outputs flow from job to job so fair,
Release pipelines, finalized and sweet! ✨

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch dev

Comment @coderabbitai help to get the list of available commands and usage tips.

@RambokDev RambokDev merged commit 94b36c1 into main Mar 6, 2026
2 of 3 checks passed
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Mar 6, 2026

Quality Gate Failed Quality Gate failed

Failed conditions
C Security Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@coderabbitai coderabbitai Bot mentioned this pull request May 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant