fix: logs noise#284
Merged
Merged
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
📝 WalkthroughWalkthroughAdds LOG_LEVEL-driven pino configuration, replaces ad-hoc console logging with module-scoped structured loggers, gates middleware API logging by severity, downgrades/adjusts several log levels, and updates development infra (mailpit) plus workspace/package metadata. ChangesLogging Infrastructure & Module Adoption
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 6
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@app/`(customer)/dashboard/(admin)/admin/settings/page.tsx:
- Line 20: The current log.debug call is emitting the full settings object
(log.debug({settings}, "Settings loaded")), which may leak sensitive
configuration; update the call to avoid serializing the full settings and
instead log only minimal metadata (e.g., settings id, name, or a boolean
presence flag). Locate the log.debug usage and replace the payload with a
minimal object such as {settingsId: settings?.id, hasSettings: !!settings} or
simply log a message with hasSettings boolean, ensuring functions/variables
referenced remain log.debug and settings so the change is localized.
In `@docker-compose.yml`:
- Line 36: The docker-compose service is using the floating image tag
"axllent/mailpit:latest"; update the image reference in docker-compose.yml to a
pinned, immutable tag or digest (e.g., replace "axllent/mailpit:latest" with a
specific version like "axllent/mailpit:<version>" or a sha256 digest) to ensure
reproducible environments and consistent behavior across machines; locate the
line containing the image declaration "axllent/mailpit:latest" and change it,
and update any docs or environment notes that reference using the latest tag.
- Line 15: The YAML lint failure is due to extra spaces inside the inline list
for the healthcheck/test entry; edit the `test` value (the inline list
containing "CMD-SHELL" and "pg_isready -U devuser -d devdb") to remove the
spaces inside the square brackets so it becomes a compact inline list (e.g.,
["CMD-SHELL","pg_isready -U devuser -d devdb"]) to satisfy YAMLlint.
In `@src/lib/logger.ts`:
- Around line 4-5: Replace the unsafe cast of LOG_LEVEL to pino.Level by
validating process.env.LOG_LEVEL at startup: create a constant array of valid
levels ["fatal","error","warn","info","debug","trace"], compute const levelStr =
process.env.LOG_LEVEL ?? defaultLevel, check if levelStr is in that array, and
if so set const level = levelStr as pino.Level; otherwise log/throw a clear
startup error and fall back to defaultLevel (matching the pattern used in
loggingMiddleware.ts) so invalid values are rejected or handled before passing
to pino.
In `@src/middleware/loggingMiddleware.ts`:
- Line 18: Replace the console.log call in loggingMiddleware.ts with the
project's pino logger: import the shared "logger" symbol at the top of the file,
then change the line that calls console.log(`[API] Received ${request.method}
request : ${request.url} at ${new Date()}`) to use logger.info (or appropriate
level) with structured fields, e.g. logger.info({ method: request.method, url:
request.url, time: new Date() }, 'API request received'); ensure you remove the
console.log reference and export/usage of the middleware remains unchanged.
- Around line 3-8: The LOG_LEVELS/LogLevel parsing in loggingMiddleware.ts
duplicates logic already in src/lib/logger.ts; remove the local constants
(LOG_LEVELS, LogLevel, raw, _idx, LEVEL_INDEX) and import the shared helper
(e.g., getConfiguredLevelIndex or similar exported function) from logger.ts,
then replace uses of LEVEL_INDEX with the imported helper's result so the
middleware relies on the single source of truth for log-level parsing.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: c5a8c2b6-5a8f-46c0-9e76-8858ff8c7abd
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (15)
.env.example.gitignoreapp/(customer)/dashboard/(admin)/admin/settings/page.tsxapp/(landing)/page.tsxapp/api/agent/[agentId]/status/route.tsdocker-compose.ymlpackage.jsonsrc/components/wrappers/dashboard/projects/button-delete-project/delete-project.action.tssrc/features/storages/dispatch.tssrc/features/upload/public/upload.action.tssrc/lib/auth/auth.tssrc/lib/logger.tssrc/lib/tasks/cleaning/index.tssrc/lib/tasks/index.tssrc/middleware/loggingMiddleware.ts
💤 Files with no reviewable changes (1)
- app/(landing)/page.tsx
📜 Review details
🧰 Additional context used
🪛 YAMLlint (1.38.0)
docker-compose.yml
[error] 15-15: too many spaces inside brackets
(brackets)
[error] 15-15: too many spaces inside brackets
(brackets)
🔇 Additional comments (19)
.gitignore (1)
58-61: LGTM!.env.example (1)
4-9: LGTM!src/lib/auth/auth.ts (4)
25-27: LGTM!
443-443: LGTM!
474-480: LGTM!
787-787: LGTM!src/features/storages/dispatch.ts (2)
14-16: LGTM!
109-109: LGTM!src/features/upload/public/upload.action.ts (3)
3-3: LGTM!Also applies to: 14-14
32-37: LGTM!
73-73: LGTM!src/components/wrappers/dashboard/projects/button-delete-project/delete-project.action.ts (2)
4-4: LGTM!Also applies to: 8-8, 12-13
57-57: LGTM!package.json (2)
131-131: ⚡ Quick winPostcss version pinning confirmed.
The pinning of
postcssto8.5.10(exact version) is valid—this version exists on npm. Ensure this explicit pinning aligns with your project's reproducibility requirements.
139-139: ⚡ Quick winpnpm@11.1.2 version verified.
The upgrade from pnpm@10.33.0 to pnpm@11.1.2 is legitimate. The version exists as a stable release (published 2026-05-14), and the integrity hash is correct and matches the official npm distribution.
src/lib/tasks/cleaning/index.ts (1)
17-17: LGTM!Also applies to: 27-27
src/lib/tasks/index.ts (1)
25-25: LGTM!app/(customer)/dashboard/(admin)/admin/settings/page.tsx (1)
4-12: LGTM!Also applies to: 39-39, 51-52
app/api/agent/[agentId]/status/route.ts (1)
34-34: LGTM!
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@pnpm-workspace.yaml`:
- Around line 1-14: Remove the legacy pnpm v10 keys `ignoredBuiltDependencies`
and `onlyBuiltDependencies` from pnpm-workspace.yaml since pnpm v11 no longer
supports them; keep the `allowBuilds` mapping as the source of truth (e.g.,
`allowBuilds.node-pty: true`) and delete the legacy entries that conflict (such
as any `ignoredBuiltDependencies: node-pty` or `onlyBuiltDependencies` blocks)
so the workspace config is not carrying dead/ignored keys.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: cc6afb59-7ff9-4010-9f7c-01c7ea4442d3
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (1)
pnpm-workspace.yaml
📜 Review details
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: build-and-test
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@package.json`:
- Line 139: package.json currently pins "packageManager" to pnpm@11.1.2 which
introduces breaking changes; update CI/dev environments to Node.js 22+, run the
pnpm-v10-to-v11 codemod to migrate configuration, move settings like
hoist-pattern/node-linker from .npmrc into pnpm-workspace.yaml or global
config.yaml (leave auth/registry in .npmrc), rename environment variables and
workflow references from npm_config_* to pnpm_config_, update CLI usages (remove
any use of pnpm server, replace pnpm install -g with pnpm add -g, and audit code
relying on pnpm link/global store behavior), and account for the new
minimum-release-age (24h) in dependency resolution; test CI and local dev after
these changes.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: 9b3e6fac-98dc-4c93-bd52-21f4087abe74
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (1)
package.json
📜 Review details
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: build-and-test
🔇 Additional comments (1)
package.json (1)
19-20: LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
New Features
Improvements
Chores