Fix : Add anthropic version header with each request#33
Closed
insaaniManav wants to merge 1 commit into
Closed
Conversation
Collaborator
|
Hey @insaaniManav . The version that you added as default now supports incremental chunk streaming. But the implementation in Rubeus does the old stream where each chunk is a combination of all the old chunks + the new one. Let me sit on it today and fix it. |
Collaborator
|
Closing this PR as this requires some more changes than just hardcoding the version header. Raised a new PR #38 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The anthropic implementation was breaking so added a version header by default , we could potentially make this configurable but there is no publically available list of versions as per my research