Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes and centralizes how Kubernetes imagePullSecrets are applied across the Portkey Gateway Helm chart so workloads can consistently pull images from private registries.
Changes:
- Adds a top-level
imagePullSecretsvalue invalues.yamland clarifies usage via comments. - Introduces a shared Helm helper (
portkeyenterprise.imagePullSecrets) to merge secrets fromimagePullSecretsandimageCredentials. - Replaces repeated
imagePullSecretstemplating blocks in multiple Deployments/StatefulSets with the shared helper include.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| charts/portkey-gateway/values.yaml | Adds/clarifies imagePullSecrets configuration and separates it from imageCredentials. |
| charts/portkey-gateway/templates/_helpers.tpl | Adds helper to render merged imagePullSecrets. |
| charts/portkey-gateway/templates/gateway/deployment.yaml | Uses the new helper to render imagePullSecrets. |
| charts/portkey-gateway/templates/dataservice/deployment.yaml | Uses the new helper to render imagePullSecrets. |
| charts/portkey-gateway/templates/redis/deployment.yaml | Uses the new helper to render imagePullSecrets. |
| charts/portkey-gateway/templates/minio/statefulset.yaml | Uses the new helper to render imagePullSecrets. |
| charts/portkey-gateway/templates/milvus/milvus-statefulset.yaml | Uses the new helper to render imagePullSecrets. |
| charts/portkey-gateway/templates/milvus/etcd-statefulset.yaml | Uses the new helper to render imagePullSecrets. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 10 out of 10 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
No description provided.