Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes and standardizes how Kubernetes imagePullSecrets are configured across the Portkey Gateway Helm chart by introducing a single helper that merges secrets provided via imagePullSecrets and imageCredentials, and updating workloads + docs to use the corrected pattern.
Changes:
- Adds a dedicated
imagePullSecretsvalue (supporting both string and{name: ...}forms) and documents how to use it vs.imageCredentials. - Introduces a Helm helper to merge/deduplicate pull secret names from
imagePullSecretsandimageCredentials. - Updates gateway/dataservice/redis/minio/milvus workloads to use the shared helper for
spec.imagePullSecrets.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| charts/portkey-gateway/values.yaml | Adds top-level imagePullSecrets: [] with guidance; removes the incorrectly placed old default. |
| charts/portkey-gateway/templates/_helpers.tpl | Adds portkeyenterprise.imagePullSecrets helper to merge/deduplicate secret names. |
| charts/portkey-gateway/templates/redis/deployment.yaml | Switches Redis pod spec to use the shared imagePullSecrets helper. |
| charts/portkey-gateway/templates/minio/statefulset.yaml | Switches MinIO pod spec to use the shared imagePullSecrets helper. |
| charts/portkey-gateway/templates/milvus/milvus-statefulset.yaml | Switches Milvus pod spec to use the shared imagePullSecrets helper. |
| charts/portkey-gateway/templates/milvus/etcd-statefulset.yaml | Switches Milvus etcd pod spec to use the shared imagePullSecrets helper. |
| charts/portkey-gateway/templates/gateway/deployment.yaml | Switches Gateway pod spec to use the shared imagePullSecrets helper. |
| charts/portkey-gateway/templates/dataservice/deployment.yaml | Switches Dataservice pod spec to use the shared imagePullSecrets helper. |
| charts/portkey-gateway/README.md | Documents two supported approaches: chart-created registry secret vs pre-existing pull secret. |
| charts/portkey-gateway/docs/Configuration.md | Updates defaults/description for imagePullSecrets and clarifies interaction with imageCredentials. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.