feat: add DNS policy and configuration options for gateway and datase…#188
Merged
feat: add DNS policy and configuration options for gateway and datase…#188
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds configurable Pod DNS settings (dnsPolicy/dnsConfig) for the gateway and dataservice Helm chart deployments, and adjusts how environment Secret data is rendered.
Changes:
- Introduces
dnsPolicyanddnsConfigvalues for both gateway and dataservice pods. - Renders
dnsPolicy/dnsConfiginto the gateway and dataservice Deployment pod specs, with validation whendnsPolicy: None. - Updates Secret generation logic for
.Values.environment.datain the gateway config template.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| charts/portkey-gateway/values.yaml | Adds new values for gateway/dataservice DNS policy and DNS config; minor env default tweak. |
| charts/portkey-gateway/templates/gateway/deployment.yaml | Applies DNS policy/config to gateway pod spec and adds Helm-time validation for None. |
| charts/portkey-gateway/templates/gateway/config.yaml | Changes how .Values.environment.data is base64-encoded into a Secret. |
| charts/portkey-gateway/templates/dataservice/deployment.yaml | Applies DNS policy/config to dataservice pod spec and adds Helm-time validation for None. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
sk-portkey
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…rvice