fix: update SERVER_MODE and MCP_GATEWAY_BASE_URL to remove empty stri…#189
Merged
fix: update SERVER_MODE and MCP_GATEWAY_BASE_URL to remove empty stri…#189
Conversation
…ngs in values.yaml
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Helm chart default configuration to avoid explicitly setting empty-string values for optional environment variables, aligning them with the other unset env entries in values.yaml.
Changes:
- Set
environment.data.SERVER_MODEto an unset (null) value instead of"". - Set
environment.data.MCP_GATEWAY_BASE_URLto an unset (null) value instead of"".
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
sk-portkey
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ngs in values.yaml