Skip to content

Dotnet template "ModuleBuilderModule"#77

Merged
Jaykul merged 5 commits intoPoshCode:masterfrom
bravo-kernel:dotnet-template
Oct 26, 2019
Merged

Dotnet template "ModuleBuilderModule"#77
Jaykul merged 5 commits intoPoshCode:masterfrom
bravo-kernel:dotnet-template

Conversation

@bravo-kernel
Copy link
Copy Markdown
Contributor

@bravo-kernel bravo-kernel commented Oct 12, 2019

Finally got to this, hereby the dotnet template, closes #64.

  • simplest solution (the initial efforts were overthought/over-engineered)
  • generates folder structure and intial manifest only
  • thus maintainable
  • can easily be extended
  • placed in a subfolder so more templates could be added (will probably never happen but hey)

To test locally as an end-user

git clone git@github.com:bravo-kernel/ModuleBuilder.git
cd ModuleBuilder
git checkout dotnet-template
dotnet new -i ./
dotnet new  # to see it's in the list
dotnet new ModuleBuilderModule --help # to see author and command line options

cd ..
dotnet new ModuleBuilderModule -o outputFolder --moduleName MyGeneratedModule  --allow-scripts yes
cd outputFolder

Build-Module .\Source\

TODO

  • review
  • include template in module publication
  • decide whether or not we want to put Install-Script Install-RequiredModule --force in the post-action script. IMO this would make things a lot more user-friendly. However, will lead to every dotnet new command doing an install
  • verify: docs say either use Classes OR Enum. If that is correct one needs to be removed from this template
  • add that for end users note to the README

I've already been using this to mass produce modules. I think this is the bridge that will make ModuleBuilder usable for the masses. Please let me know what you think so we can get this out there.

@Jaykul
Copy link
Copy Markdown
Member

Jaykul commented Oct 23, 2019

I'm so slow. I will review tonight or tommorrow.

@bravo-kernel
Copy link
Copy Markdown
Contributor Author

bravo-kernel commented Oct 23, 2019

@Jaykul that would be cool, I hope you can approach this as "first make it work, then make it better" basis. I see this template complementing https://docusaurus-powershell.netlify.com/ (and vice-versa).

},
"classifications": ["Powershell", "Modules"],
"name": "ModuleBuilder Module Generator",
"shortName": "ModuleBuilderModule",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use a less verbose shortname here?

Suggested change
"shortName": "ModuleBuilderModule",
"shortName": "PSMBModule",

@bravo-kernel
Copy link
Copy Markdown
Contributor Author

We can rename shortName to whatever we like as long as there is consensus, this name just came up in the original discussion #64 . This is how it looks in the list atm:

image

@Jaykul
Copy link
Copy Markdown
Member

Jaykul commented Oct 26, 2019

This looks pretty good. I'm going to merge it, and then improve :-)

@bravo-kernel
Copy link
Copy Markdown
Contributor Author

Awesome, more to come, let’s make this happen :)

@Jaykul Jaykul merged commit 1acd686 into PoshCode:master Oct 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FP] New-ModuleSkeleton

3 participants