Dotnet template "ModuleBuilderModule"#77
Merged
Jaykul merged 5 commits intoPoshCode:masterfrom Oct 26, 2019
Merged
Conversation
This was referenced Oct 12, 2019
Closed
f4c6d5d to
f10c530
Compare
Member
|
I'm so slow. I will review tonight or tommorrow. |
Contributor
Author
|
@Jaykul that would be cool, I hope you can approach this as "first make it work, then make it better" basis. I see this template complementing https://docusaurus-powershell.netlify.com/ (and vice-versa). |
kilasuit
reviewed
Oct 23, 2019
| }, | ||
| "classifications": ["Powershell", "Modules"], | ||
| "name": "ModuleBuilder Module Generator", | ||
| "shortName": "ModuleBuilderModule", |
Contributor
There was a problem hiding this comment.
Can we use a less verbose shortname here?
Suggested change
| "shortName": "ModuleBuilderModule", | |
| "shortName": "PSMBModule", |
Contributor
Author
|
We can rename |
Member
|
This looks pretty good. I'm going to merge it, and then improve :-) |
Contributor
Author
|
Awesome, more to come, let’s make this happen :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Finally got to this, hereby the dotnet template, closes #64.
To test locally as an end-user
TODO
Install-Script Install-RequiredModule --forcein the post-action script. IMO this would make things a lot more user-friendly. However, will lead to everydotnet newcommand doing an installClassesOREnum. If that is correct one needs to be removed from this templatefor end usersnote to the README