Skip to content

CI - ClickHouse default ClusterIP #617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 7, 2022
Merged

CI - ClickHouse default ClusterIP #617

merged 1 commit into from
Nov 7, 2022

Conversation

@guidoiaquinti
Copy link
Contributor

@guidoiaquinti guidoiaquinti commented Nov 7, 2022 •
edited
Loading

Description

  • add test to make sure the default ClickHouse service type is ClusterIP
  • upgrade ESLint (not strictly part of this PR but I had it in my checkout)

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

How has this been tested?

CI is ✅

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@guidoiaquinti guidoiaquinti changed the title CI - ClickHouse default nodeport CI - ClickHouse default ClusterIP Nov 7, 2022
@guidoiaquinti guidoiaquinti marked this pull request as ready for review November 7, 2022 14:55
@guidoiaquinti guidoiaquinti requested a review from ellie November 7, 2022 14:56
@guidoiaquinti guidoiaquinti merged commit 86d3776 into main Nov 7, 2022
@guidoiaquinti guidoiaquinti deleted the ci_sss branch November 7, 2022 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ellie ellie Awaiting requested review from ellie

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@guidoiaquinti