Skip to content

Conversation

@ellie
Copy link
Contributor

@ellie ellie commented Jan 12, 2023

I'd like to test some changes on cloud, and we need to make this configurable for that to happen.

I've set the default values to be the kubernetes defaults, so this should be a no-op until other configuration occurs.

Description

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

How has this been tested?

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

Ellie Huxtable added 2 commits January 12, 2023 16:13
I'd like to test some changes on cloud, and we need to make this
configurable for that to happen.
Copy link
Contributor

@danielxnj danielxnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ellie ellie merged commit d600231 into main Jan 13, 2023
@ellie ellie deleted the ellie/rollout-adjustments branch January 13, 2023 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants