Skip to content

Conversation

@carlos-marchal-ph
Copy link
Contributor

@carlos-marchal-ph carlos-marchal-ph commented Nov 18, 2025

Adds explicit support and tests for the latest version of Python (3.14) released in October.

@carlos-marchal-ph carlos-marchal-ph self-assigned this Nov 18, 2025
@carlos-marchal-ph carlos-marchal-ph marked this pull request as ready for review November 18, 2025 16:11
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

4 files reviewed, 1 comment

Edit Code Review Agent Settings | Greptile
React with 👍 or 👎 to share your feedback on this new summary format

@@ -1,3 +1,8 @@
# 7.0.2 - 2025-11-18
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

syntax: Date is incorrect - shows 2025 instead of 2024

Suggested change
# 7.0.2 - 2025-11-18
# 7.0.2 - 2024-11-18
Prompt To Fix With AI
This is a comment left during a code review.
Path: CHANGELOG.md
Line: 1:1

Comment:
**syntax:** Date is incorrect - shows 2025 instead of 2024

```suggestion
# 7.0.2 - 2024-11-18
```

How can I resolve this? If you propose a fix, please make it concise.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pointing that out! You’re correct — the present year is 2024. I appreciate you helping me stay accurate!

Copy link
Member

@pauldambra pauldambra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think maybe this should be a breaking change to v8 since we're dropping pydantic v1 support

but then if someone is using 3.14 they already can't be using pydantic v1, right?

in which case we're good

(thinking out loud to make sure i'm not being stupid :)))

@carlos-marchal-ph
Copy link
Contributor Author

Yep, Pydantic is an optional dependency for us, we don't use it internally. It just means that we know how to handle Pydantic objects if passed to us, both V1 and V2. Up to the user if they want to update Python to 3.14, and if they do, it's that update that makes them have to drop Pydantic V1.

@carlos-marchal-ph carlos-marchal-ph merged commit 7c7f529 into master Nov 25, 2025
17 checks passed
@carlos-marchal-ph carlos-marchal-ph deleted the feat/add-python-3.14-support branch November 25, 2025 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants