acbr5 conflict çözüldü, API requestleri class yapısına alındı. Navbar için querystring bugı çözüldü.

Classes/API.php

@@ -0,0 +1,47 @@
+<?php
+
+namespace Classes;
+
+class API
+{
+
+    private $config;
+    private $baseUrl = 'https://www.potterapi.com/v1/';
+
+    public function __construct()
+    {
+        $this->config = include 'config.php';
+    }
+
+    protected function makeRequest($method, array $params = [])
+    {
+        //methoda göre api url oluşturuyoruz
+        $apiUrl = $this->baseUrl.$method.'?key='.$this->config['api_key'];
+
+        //varsa ek parametreleri ekliyoruz özellikle karakterlerin evleri için
+        foreach ($params as $key => $value) {
+            $apiUrl .= '&'.$key.'='.$value;
+        }
+
+        $ch = curl_init();
+        curl_setopt($ch, CURLOPT_URL, $apiUrl);
+        curl_setopt($ch, CURLOPT_RETURNTRANSFER, true);
+        $output = curl_exec($ch);
+        $statusCode = curl_getinfo($ch, CURLINFO_HTTP_CODE);
+        curl_close($ch);
+
+
+        //hatalı parametreler için 409 dönüyor daha detaylı hata için aşağıda kontrol yapıldı
+        if ($statusCode !== 200 && $statusCode != 409) {
+            die('API bağlantısı çalışmıyor');
+        }
+        $array = json_decode($output, true);
+
+        if (isset($array['error'])) {
+            die('API parametreleri hatalı: '.$array['error']);
+        }
+
+        return $array;
+
+    }
+}

Classes/Character.php

@@ -0,0 +1,41 @@
+<?php
+
+
+namespace Classes;
+
+
+class Character extends API
+{
+
+    private $validHouses = ['Gryffindor', 'Ravenclaw', 'Slytherin', 'Hufflepuff'];
+
+    public function getCharacters($house = null)
+    {
+
+        $params = [];
+
+        if ($house && !in_array($_GET['house'], $this->validHouses)) {
+            die('Böyle bir ev yok');
+        } elseif ($house) {
+            $params = ['house' => $house];
+        }
+
+
+        $characters = $this->makeRequest('characters', $params);
+
+        $list = [];
+
+        foreach ($characters as $character) {
+            $list[] = [
+                'name' => $character['name'],
+                'image' => 'assets/images/characters/'.$character['name'].'.jpg',
+                'house' => $character['house'] ?? '',
+                'role' => $character['role'] ?? '',
+                'bloodStatus' => $character['bloodStatus'],
+                'species' => $character['species']
+            ];
+        }
+
+        return $list;
+    }
+}

Classes/House.php

@@ -0,0 +1,32 @@
+<?php
+
+
+namespace Classes;
+
+
+class House extends API
+{
+
+
+    public function getHouses()
+    {
+
+        $houses = $this->makeRequest('houses');
+
+
+        $list = [];
+
+        foreach ($houses as $house) {
+            $list[] = [
+                'name' => $house['name'],
+                'founder' => $house['founder'] ?? 'Mevcut Değil',
+                'headOfHouse' => $house['headOfHouse'] ?? 'Mevcut Değil',
+                'mascot' => $house['mascot'] ?? 'Mevcut Değil',
+                'houseGhost' => $house['houseGhost'] ?? 'Mevcut Değil',
+                'school' => $house['school'] ?? 'Mevcut Değil'
+            ];
+        }
+
+        return $list;
+    }
+}

Classes/Spell.php

@@ -0,0 +1,27 @@
+<?php
+
+
+namespace Classes;
+
+
+class Spell extends API
+{
+
+
+    public function getSpells()
+    {
+        $spells = $this->makeRequest('spells');
+
+        $list = [];
+
+        foreach ($spells as $spell) {
+            $list[] = [
+                'spell' => $spell['spell'],
+                'type' => $spell['type'],
+                'effect' => $spell['effect'],
+            ];
+        }
+
+        return $list;
+    }
+}

base.inc.php

@@ -0,0 +1,8 @@
+<?php
+
+$classPath = __DIR__.DIRECTORY_SEPARATOR.'Classes'.DIRECTORY_SEPARATOR;
+
+include_once $classPath.'API.php';
+include_once $classPath.'House.php';
+include_once $classPath.'Spell.php';
+include_once $classPath.'Character.php';

characters.php

@@ -1,40 +1,15 @@
 <?php
 
-$config = include 'config.php';
+include_once 'base.inc.php';
 
 function getTitle()
 {
     return 'Karakterler';
 }
 
-$apiUrl = "https://www.potterapi.com/v1/characters?key={$config['api_key']}";
-
-//hello
-if (isset($_GET['house'])) {
-    $validHouses = ['gryffindor', 'ravenclaw', 'slytherin', 'hufflepuff'];
-
-    if (!in_array($_GET['house'], $validHouses)) {
-        exit('Böyle bir ev yok');
-    }
-
-    $apiUrl .= ($_GET['house'] ? "&house=" . ucfirst($_GET['house']) : '');
-}
-
-$characters = file_get_contents($apiUrl);
-
-$characterDetails = [];
-
-$characters = json_decode($characters, true);
+$characterClass = new \Classes\Character();
 
-foreach ($characters as $character) {
-    $characterDetails[] = [
-        'name' => $character['name'],
-        'house' => $character['house'] ?? '',
-        'role' => $character['role'] ?? '',
-        'bloodStatus' => $character['bloodStatus'],
-        'species' => $character['species']
-    ];
-}
+$characters = $characterClass->getCharacters($_GET['house'] ?? null);
 
 ?>
 
@@ -63,30 +38,43 @@ function getTitle()
                 <thead>
                 <tr>
                     <th scope="col">#</th>
-                    <th scope="col">Name</th>
-                    <th scope="col">House</th>
-                    <th scope="col">Role</th>
-                    <th scope="col">Blood</th>
-                    <th scope="col">Species</th>
+                    <th scope="col">Avatar</th>
+                    <th scope="col">Ad</th>
+                    <th scope="col">Rol</th>
+                    <th scope="col">Ev</th>
+                    <th scope="col">Kan Durumu</th>
+                    <th scope="col">Tür</th>
                 </tr>
                 </thead>
                 <tbody>
                 <?php
                 $counter = 1;
-                foreach ($characterDetails as $detail):
-                    if (!isset($_GET['house']) || $_GET['house'] == strtolower($detail['house'])) {
-                        ?>
-                        <tr>
-                            <th scope="row"><?php echo $counter++; ?> </th>
-                            <td><?php echo $detail['name']; ?></td>
-                            <td><?php echo $detail['house']; ?></td>
-                            <td><?php echo $detail['role']; ?></td>
-                            <td><?php echo $detail['bloodStatus']; ?></td>
-                            <td><?php echo $detail['species']; ?></td>
-                        </tr>
-                        <?php
-                    }
-                endforeach;
+                foreach ($characters as $character){ ?>
+
+                    <tr>
+                        <th scope="row"><?php echo $counter++; ?> </th>
+                        <td><img style=" width: 40%; height: auto;" alt="" class="card-img-top" src="<?php echo $character['image']; ?>"></td>
+                        <td><?php echo $character['name'];?></td>
+                        <td><?php echo $character['role'];?></td>
+                        <td><?php echo $character['house'];?></td>
+                        <td><?php echo $character['bloodStatus'];?></td>
+                        <td><?php echo $character['species'];?></td>
+                        <!--
+                            Translate API için kullandım ama biraz yavaş yüklendiği için yorum satırı içerisine aldım
+                            <th scope="row"><?//php echo $counter++; ?> </th>
+                            <td><img style=" width: 40%; height: auto;" alt="" class="card-img-top" src="assets/images/characters/<?//php echo $detail['name']?>.jpg"></td>
+                            <td><?//php echo $detail['name'];?></td>
+                            <td><?//php translate("".$detail['role'], "en", "tr");?></td>
+                            <td><?//php echo $detail['house'];?></td>
+                            <td><?//php translate("".$detail['bloodStatus'], "en", "tr");?></td>
+                            <td><?//php translate("".$detail['species'], "en", "tr");?></td>
+                            -->
+                    </tr>
+
+                <?php }
+
+
+
                 ?>
                 </tbody>
             </table>

houses.php

@@ -1,25 +1,15 @@
 <?php
 
-$config = include 'config.php';
+include_once 'base.inc.php';
+
 
 function getTitle()
 {
     return 'Evler';
 }
 
-$houses = file_get_contents("https://www.potterapi.com/v1/houses?key={$config['api_key']}");
-
-$decodedHouses = json_decode($houses, true);
-$houseDetails = [];
-
-foreach ($decodedHouses as $house) {
-    $houseDetails[] = [
-        'name' => $house['name'],
-        'founder' => $house['founder'],
-        'headOfHouse' => $house['headOfHouse']
-    ];
-}
-
+$houseClass = new \Classes\House();
+$houses = $houseClass->getHouses();
 
 ?>
 
@@ -33,39 +23,48 @@ function getTitle()
 
 
 <div class="pt-5">
-
     <div class="container">
-
         <section class="jumbotron text-center pt-5 mb-5 bg-white">
             <div class="container">
                 <h1 class="jumbotron-heading"><?php echo getTitle(); ?></h1>
             </div>
         </section>
-
         <div class="row bg-white p-5">
-            <?php  foreach ($houseDetails as $detail) { ?>
+            <?php foreach ($houses as $house) { ?>
                 <div class="col-md-6">
                     <div class="card mb-4 box-shadow">
-                        <img class="card-img-top" src="/assets/images/<?php echo $detail['name'] ?>.jpg" alt="<?php echo $detail['name']; ?>">
+                        <img class="card-img-top" src="assets/images/houses/<?php echo $house['name'] ?>.jpg"
+                             alt="<?php echo $house['name']; ?>">
                         <div class="card-body">
-                            <h5 class="card-title"><?php echo $detail['name']; ?></h5>
+                            <h5 align="center" class="card-title">
+                                <strong><?php echo strtoupper($house['name']); ?></strong></h5>
                             <p class="card-text">
-                                <ul>
-                                    <li><strong>Founder: </strong><?php echo $detail['founder']; ?></li>
-                                    <li><strong>Head of House: </strong><?php echo $detail['headOfHouse']; ?></li>
-                                </ul>
-
+                                <strong>Evin Kurucusu :</strong> <?php echo $house['founder']; ?>
+                            </p>
+                            <p class="card-text">
+                                <strong>Evin Başı &emsp; &emsp; :</strong> <?php echo $house['headOfHouse']; ?>
+                            </p>
+                            <p class="card-text">
+                                <strong>Evin Maskotu&emsp;:</strong> <?php echo ucfirst($house['mascot']); ?>
+                            </p>
+                            <p class="card-text">
+                                <strong> Evin Hayaleti &emsp;:</strong> <?php echo $house['houseGhost']; ?>
+                            </p>
+                            <p class="card-text">
+                                <strong> Okul &emsp;&emsp;&emsp;&emsp;&emsp;:</strong> <?php echo $house['school']; ?>
                             </p>
                             <div class="justify-content-between align-items-center">
                                 <div class="btn-group float-right">
-                                    <a href="characters.php?house=<?php echo strtolower($detail['name']); ?>" class="btn btn-sm btn-outline-secondary">Show Students</a>
+                                    <a href="characters.php?house=<?php echo $house['name']; ?>"
+                                       class="btn btn-sm btn-outline-secondary">Show Students</a>
                                 </div>
                             </div>
                         </div>
                     </div>
                 </div>
 
             <?php } ?>
+
         </div>
     </div>
 </div>

index.php

@@ -33,8 +33,12 @@ function getTitle()
         <div class="bg-white p-5">
             <div class="col-md-12">
 
-
-                <p>Tebrikler! Seçmen şapka sizi <strong><?php echo $house; ?></strong> evine yerleştirdi.</p>
+                <?php
+                // api'dan gelen çift tırnak işaretlerini kaldırmak için yazıldı
+                $house = str_replace("\"","", $house);
+                ?>
+                <p>Tebrikler! Seçmen şapka sizi <strong><a href="houses.php"><?php echo $house; ?></a></strong> evine yerleştirdi.</p>
+                <img class="card-img-top" src="assets/images/houses/<?php echo $house?>.jpg" alt="<?php echo $house; ?>">
 
             </div>
         </div>

navbar.php

@@ -12,7 +12,7 @@
                         <a class="nav-link <?php if ($_SERVER['REQUEST_URI'] == '/index.php') { echo 'active'; } ?>" href="index.php">Anasayfa</a>
                     </li>
                     <li class="nav-item">
-                        <a class="nav-link <?php if ($_SERVER['REQUEST_URI'] == '/characters.php') { echo 'active'; } ?>" href="characters.php">Karakterler</a>
+                        <a class="nav-link <?php if (strpos($_SERVER['REQUEST_URI'],'/characters.php') !== false) { echo 'active'; } ?>" href="characters.php">Karakterler</a>
                     </li>
                     <li class="nav-item">
                         <a class="nav-link <?php if ($_SERVER['REQUEST_URI'] == '/houses.php') { echo 'active'; } ?>" href="houses.php">Evler</a>