Skip to content

dnsdist-2.1.x: Backport 17544 - Do not let exceptions cross the FFI boundary#17650

Merged
rgacogne merged 1 commit into
PowerDNS:rel/dnsdist-2.1.xfrom
rgacogne:ddist21-backport-17544
Jun 30, 2026
Merged

dnsdist-2.1.x: Backport 17544 - Do not let exceptions cross the FFI boundary#17650
rgacogne merged 1 commit into
PowerDNS:rel/dnsdist-2.1.xfrom
rgacogne:ddist21-backport-17544

Conversation

@rgacogne

Copy link
Copy Markdown
Member

Short description

Backport #17544 to rel/dnsdist-2.1.x

Checklist

I have:

  • read the CONTRIBUTING.md document
  • read and accepted the Developer Certificate of Origin document, including the AI Policy, and added a "Signed-off-by" to my commits
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
  • checked that this code was merged to master

As we learned that on at least some ARM platforms "External frame unwinding"
is not available / working well.
None of these changes should be a security issue as they should not be triggerable
via attacker-controlled data, but they will make debugging of flawed Lua code easier.

Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>
(cherry picked from commit 9eb47f2)
@rgacogne rgacogne added this to the dnsdist-2.1.x milestone Jun 30, 2026
@coveralls

Copy link
Copy Markdown

Coverage Report for CI Build 28435121997

Warning

Build has drifted: This PR's base is out of sync with its target branch, so coverage data may include unrelated changes.
Quick fix: rebase this PR. Learn more →

Coverage decreased (-0.09%) to 68.796%

Details

  • Coverage decreased (-0.09%) from the base build.
  • Patch coverage: 55 uncovered changes across 1 file (112 of 167 lines covered, 67.07%).
  • 18 coverage regressions across 4 files.

Uncovered Changes

File Changed Covered %
pdns/dnsdistdist/dnsdist-lua-ffi.cc 167 112 67.07%

Coverage Regressions

18 previously-covered lines in 4 files lost coverage.

File Lines Losing Coverage Coverage
pdns/dnsdistdist/dnsdist-tcp.cc 7 74.87%
pdns/misc.cc 6 42.31%
pdns/dnsdistdist/dnsdist-lua-ffi.cc 3 67.72%
pdns/iputils.hh 2 73.51%

Coverage Stats

Coverage Status
Relevant Lines: 71240
Covered Lines: 54234
Line Coverage: 76.13%
Relevant Branches: 30902
Covered Branches: 16036
Branch Coverage: 51.89%
Branches in Coverage %: Yes
Coverage Strength: 2497925.55 hits per line

💛 - Coveralls

@rgacogne rgacogne merged commit e63f201 into PowerDNS:rel/dnsdist-2.1.x Jun 30, 2026
18 checks passed
@rgacogne rgacogne deleted the ddist21-backport-17544 branch June 30, 2026 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants