Additional metrics and some tests for metrics #110
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- New histogram metric measuring the duration of S3 calls by method - New counter recording errors by method and error type (this is intended to replace the existing metric that just records errors by method)
… for lower cardinality and better reproducibility in tests
wojas
approved these changes
Oct 30, 2025
Member
wojas
left a comment
wojas
left a comment
There was a problem hiding this comment.
LGTM!
I was not aware of the existence of the prometheus testutil.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two new metrics are added:
storage_s3_call_error_by_type_total- Which adds an error type label; this is intended to replace the existingstorage_s3_call_error_totalmetric over time, which only counts errors but not what type of error. A new metric was considered preferable to adding a label to an existing metric.storage_s3_call_duration_seconds- Tracks the duration of each s3 method in a histogramSome basic tests for the metrics are also added.