Nightly fix: Update nightly for renaming #300
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nitish Bharambe <78108900+nitbharambe@users.noreply.github.com>
|
Member
|
Can you explain how this relates to #296? |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the nightly workflow file based on the recent renaming changes from the previous PR.
- Updated the workflow file reference from build-test-and-sonar.yml to ci.yml.
- Adjusted the nightly CI pipeline accordingly.
Comments suppressed due to low confidence (1)
.github/workflows/nightly.yml:19
- Please ensure that the new workflow file ('ci.yml') includes all the required steps (such as publishing to PyPI) from the previous build-test-and-sonar.yml workflow to maintain consistent nightly builds.
uses: "./.github/workflows/ci.yml"
Member
Author
The file name was renamed to ci.yml in that PR |
petersalemink95
approved these changes
May 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nightly failed in https://github.com/PowerGridModel/power-grid-model-io/actions/runs/14986900277/workflow
As per changes in #296, the nightly file needs to be updated too.
Verify if this renaming is okay or not, since the above PR has additional contents regarding publishing at pypi.