Nightly build fail: Move publishing out of nightly #301
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
nitbharambe
commented
May 15, 2025
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
mgovers
previously approved these changes
May 22, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
|
figueroa1395
approved these changes
May 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was attempted in #296 and relates to changes in #300
Changes proposed in this PR include:
In #300, it was missed that we need to move publishing part out of nightly, but its present in ci.yml.
The diff is huge, the change is simple. Intention is to create a common job of
build-test-releasewhich is ran inciand innightly. (The way it was before.)Now ci.yml is left with
build-test-releasejobs andpublish.