Reduce usage of shared_ptr in the core#1248
Merged
Conversation
Signed-off-by: Laurynas Jagutis <laurynas.jagutis@alliander.com>
Signed-off-by: Laurynas Jagutis <laurynas.jagutis@alliander.com>
Signed-off-by: Laurynas Jagutis <laurynas.jagutis@alliander.com>
Signed-off-by: Laurynas Jagutis <laurynas.jagutis@alliander.com>
…test Signed-off-by: Laurynas Jagutis <laurynas.jagutis@alliander.com>
Signed-off-by: Laurynas Jagutis <laurynas.jagutis@alliander.com>
Signed-off-by: Laurynas Jagutis <laurynas.jagutis@alliander.com>
Signed-off-by: Laurynas Jagutis <laurynas.jagutis@alliander.com>
mgovers
reviewed
Jan 12, 2026
...odel_c/power_grid_model/include/power_grid_model/math_solver/iterative_current_pf_solver.hpp
Outdated
Show resolved
Hide resolved
power_grid_model_c/power_grid_model/include/power_grid_model/math_solver/measured_values.hpp
Outdated
Show resolved
Hide resolved
...d_model_c/power_grid_model/include/power_grid_model/math_solver/newton_raphson_se_solver.hpp
Show resolved
Hide resolved
power_grid_model_c/power_grid_model/include/power_grid_model/math_solver/sparse_lu_solver.hpp
Outdated
Show resolved
Hide resolved
Signed-off-by: Laurynas Jagutis <laurynas.jagutis@alliander.com>
Signed-off-by: Laurynas Jagutis <laurynas.jagutis@alliander.com>
Signed-off-by: Laurynas Jagutis <laurynas.jagutis@alliander.com>
mgovers
reviewed
Jan 20, 2026
Member
mgovers
left a comment
mgovers
left a comment
There was a problem hiding this comment.
this is close to being merged but i feel like there are still some low-hanging fruits that we can do before merging
...model_c/power_grid_model/include/power_grid_model/math_solver/iterative_linear_se_solver.hpp
Show resolved
Hide resolved
power_grid_model_c/power_grid_model/include/power_grid_model/math_solver/measured_values.hpp
Outdated
Show resolved
Hide resolved
...d_model_c/power_grid_model/include/power_grid_model/math_solver/newton_raphson_pf_solver.hpp
Outdated
Show resolved
Hide resolved
...d_model_c/power_grid_model/include/power_grid_model/math_solver/newton_raphson_se_solver.hpp
Outdated
Show resolved
Hide resolved
..._grid_model_c/power_grid_model/include/power_grid_model/math_solver/short_circuit_solver.hpp
Outdated
Show resolved
Hide resolved
power_grid_model_c/power_grid_model/include/power_grid_model/math_solver/y_bus.hpp
Show resolved
Hide resolved
Signed-off-by: Laurynas Jagutis <laurynas.jagutis@alliander.com>
Signed-off-by: Laurynas Jagutis <laurynas.jagutis@alliander.com>
…ath_solver/iterative_linear_se_solver.hpp Co-authored-by: Martijn Govers <martijn.govers@alliander.com> Signed-off-by: Laurynas Jagutis <107866003+Laurynas-Jagutis@users.noreply.github.com>
Signed-off-by: Laurynas Jagutis <laurynas.jagutis@alliander.com>
|
mgovers
approved these changes
Jan 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #994
So far using references, reference wrappers to replace shared_ptr.