Skip to content

Allow source short circuit power to be updated for batch calculation#1369

Merged
mgovers merged 11 commits intomainfrom
pgm/feature/source-sk-updatable
Apr 15, 2026
Merged

Allow source short circuit power to be updated for batch calculation#1369
mgovers merged 11 commits intomainfrom
pgm/feature/source-sk-updatable

Conversation

@TonyXiang8787
Copy link
Copy Markdown
Member

@TonyXiang8787 TonyXiang8787 commented Apr 14, 2026 •
edited
Loading

Fixes #1156

Check list

  • Adjust component
  • Adjust math model
  • Validation test
  • Component documentation
  • Data validator (no need to adjust, logic is already there)

@TonyXiang8787
add new update attributes
f0450d4 
Signed-off-by: Tony Xiang <19280867+TonyXiang8787@users.noreply.github.com>
@TonyXiang8787
adjust members
daaf469 
Signed-off-by: Tony Xiang <19280867+TonyXiang8787@users.noreply.github.com>
@TonyXiang8787
update source sk
f11d54a 
Signed-off-by: Tony Xiang <19280867+TonyXiang8787@users.noreply.github.com>
@TonyXiang8787
test source correct, but heap overflow on others
dc4a7da 
Signed-off-by: Tony Xiang <19280867+TonyXiang8787@users.noreply.github.com>
@TonyXiang8787
fix bug
cd31e23 
Signed-off-by: Tony Xiang <19280867+TonyXiang8787@users.noreply.github.com>
@TonyXiang8787
change docs
08fa9bc 
Signed-off-by: Tony Xiang <19280867+TonyXiang8787@users.noreply.github.com>
@TonyXiang8787
remove assert
f1f5022 
Signed-off-by: Tony Xiang <19280867+TonyXiang8787@users.noreply.github.com>
@TonyXiang8787
update source param
98712fd 
Signed-off-by: Tony Xiang <19280867+TonyXiang8787@users.noreply.github.com>
@TonyXiang8787
add test, not correct yet
574b94d 
Signed-off-by: Tony Xiang <19280867+TonyXiang8787@users.noreply.github.com>
@TonyXiang8787
validation test fixed
3c764f9 
Signed-off-by: Tony Xiang <19280867+TonyXiang8787@users.noreply.github.com>
@TonyXiang8787
fix test
cc6b468 
Signed-off-by: Tony Xiang <19280867+TonyXiang8787@users.noreply.github.com>
@TonyXiang8787 TonyXiang8787 added the feature New feature or request label Apr 14, 2026
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Apr 14, 2026

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
93.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

mgovers
mgovers reviewed Apr 14, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@mgovers mgovers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 minor comments

Comment thread power_grid_model_c/power_grid_model/include/power_grid_model/component/source.hpp
Comment thread power_grid_model_c/power_grid_model/include/power_grid_model/math_solver/y_bus.hpp
@TonyXiang8787 TonyXiang8787 enabled auto-merge April 15, 2026 07:10
@TonyXiang8787 TonyXiang8787 added this pull request to the merge queue Apr 15, 2026
@mgovers mgovers removed this pull request from the merge queue due to a manual request Apr 15, 2026
@mgovers mgovers added this pull request to the merge queue Apr 15, 2026
@mgovers
Copy link
Copy Markdown
Member

mgovers commented Apr 15, 2026

sorry, my bad, i thought about

Data validator (no need to adjust, logic is already there)

and second-guessed that statement but you're right: if it is part of the update data created by initialize_array, then the data validator will handle the rest of the logic correctly

Merged via the queue into main with commit b14330c Apr 15, 2026
31 of 32 checks passed
@mgovers mgovers deleted the pgm/feature/source-sk-updatable branch April 15, 2026 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mgovers mgovers mgovers approved these changes

@nitbharambe nitbharambe Awaiting requested review from nitbharambe

Assignees

No one assigned

Labels

feature New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[FEATURE] Batch for source mode parameters (sk, rx_ration, z01_ratio)

2 participants

@TonyXiang8787 @mgovers