Skip to content

Merge links on nodes: Entry point#1370

Merged
figueroa1395 merged 11 commits intomainfrom
feature/links-part-4
Apr 20, 2026
Merged

Merge links on nodes: Entry point#1370
figueroa1395 merged 11 commits intomainfrom
feature/links-part-4

Conversation

@figueroa1395
Copy link
Copy Markdown
Member

@figueroa1395 figueroa1395 commented Apr 14, 2026

This is the entry point for the merging links into nodes algorithm plus end-to-end testing.

Some additional cleanup is done to also round this up.

Signed-off-by: marc van raalte <marc.van.raalte@alliander.com>
@figueroa1395 figueroa1395 added feature New feature or request do-not-merge This should not be merged labels Apr 14, 2026
@figueroa1395
Copy link
Copy Markdown
Member Author

do-not-merge label added so this PR is not merged accidentally before #1359

marcvanraalte and others added 3 commits April 15, 2026 12:32
Signed-off-by: marc van raalte <marc.van.raalte@alliander.com>
Signed-off-by: Santiago Figueroa Manrique <figueroa1395@gmail.com>
Base automatically changed from feature/links-part-3 to main April 16, 2026 08:38
Signed-off-by: Santiago Figueroa Manrique <figueroa1395@gmail.com>
@figueroa1395 figueroa1395 removed the do-not-merge This should not be merged label Apr 16, 2026
mgovers
mgovers previously approved these changes Apr 20, 2026
Copy link
Copy Markdown
Member

@mgovers mgovers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just some nitpicks. feel free to resolve them

Comment thread power_grid_model_c/power_grid_model/include/power_grid_model/link_solver.hpp Outdated
Comment thread power_grid_model_c/power_grid_model/include/power_grid_model/link_solver.hpp Outdated
Comment thread power_grid_model_c/power_grid_model/include/power_grid_model/link_solver.hpp Outdated
Signed-off-by: Santiago Figueroa Manrique <figueroa1395@gmail.com>
mgovers
mgovers previously approved these changes Apr 20, 2026
Comment thread power_grid_model_c/power_grid_model/include/power_grid_model/link_solver.hpp Outdated
Signed-off-by: Santiago Figueroa Manrique <figueroa1395@gmail.com>
Comment thread power_grid_model_c/power_grid_model/include/power_grid_model/link_solver.hpp Outdated
Signed-off-by: Santiago Figueroa Manrique <figueroa1395@gmail.com>
@sonarqubecloud
Copy link
Copy Markdown

@figueroa1395 figueroa1395 added this pull request to the merge queue Apr 20, 2026
Merged via the queue into main with commit 78b616b Apr 20, 2026
31 checks passed
@figueroa1395 figueroa1395 deleted the feature/links-part-4 branch April 20, 2026 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants