Reproducible build: fix MSVC build reproducibility#1407
Merged
Conversation
Member
Author
|
|
nitbharambe
previously approved these changes
May 26, 2026
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
bf241a5 to
a14e043
Compare
fdf6da3 to
a14e043
Compare
TonyXiang8787
approved these changes
May 26, 2026
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



The MSVC build reproducibility failed recently (see e.g. https://github.com/PowerGridModel/power-grid-model/actions/runs/26438097171/job/77825539883)
The underlying reason seems to be related to a couple things related to the debug directories: (tested using
dumpbin /HEADERS <first> <second>and also with a full check usingdumpbin /ALL <first> <second>)Changes in this PR
RelWithDebInfotoReleaseto get rid of more debug symbolsCMakeUserPresets.jsonTO BREAK FOR SOME DEVELOPERS/debug:Noneto forceDebug Directoriesto be reproducible (creates aNonestring instead)/NOCOFFGRPINFOto remove theCOFFGRPdirectory from theDebug Directories/LTCGto disable the default fast linking code generation (which is not fully disabled by disabling incremental build)Test case
First
Second
After this PR
where the pointer and bytes are both consistent across multiple builds
To test
dumpbin /ALL <first> <second>)