feat: source selection modal for connection import (XTB vs PPTB)#500
feat: source selection modal for connection import (XTB vs PPTB)#500Power-Maverick merged 2 commits intodevfrom
Conversation
…t hint Agent-Logs-Url: https://github.com/PowerPlatformToolBox/desktop-app/sessions/007d517e-6939-4a4e-9019-cb7badde489d Co-authored-by: Power-Maverick <36135520+Power-Maverick@users.noreply.github.com>
Bundle Size Report 📦
Bundle Analysis ReportsThe detailed bundle analysis reports are available in the workflow artifacts:
Download the artifacts from the workflow run to view interactive visualizations. Bundle size tracking is now active! This helps prevent bundle bloat. |
There was a problem hiding this comment.
Pull request overview
Adds an explicit “import source” selection step before the connection import file picker, to remove ambiguity between XrmToolBox (XML) and Power Platform ToolBox (JSON) imports in the renderer connection management flow.
Changes:
- Introduced a new BrowserWindow modal (controller + view) to select import source (XTB vs PPTB) and show XTB export guidance.
- Updated
importConnections()to open the source selection modal first, then open a format-restricted file picker and parse accordingly. - Added modal wiring (channels + promise handlers) in
connectionManagement.tsusing the existing modalBridge pattern.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| src/renderer/modules/connectionManagement.ts | Adds a new modal bridge + promise flow and updates importConnections() to use source selection before file picking/parsing. |
| src/renderer/modals/importConnectionSource/view.ts | New modal UI with two selectable cards (XTB/PPTB) and an XTB export hint panel. |
| src/renderer/modals/importConnectionSource/controller.ts | New modal controller script wiring selection, cancel/close, and confirm messaging via modalBridge. |
…ath functionality
Bundle Size Report 📦
Bundle Analysis ReportsThe detailed bundle analysis reports are available in the workflow artifacts:
Download the artifacts from the workflow run to view interactive visualizations. Bundle size tracking is now active! This helps prevent bundle bloat. |
Replaces the combined file picker + format auto-detection with an explicit source selection modal before the file picker opens. Resolves user confusion around importing XrmToolBox connections.
Changes
New modal (
src/renderer/modals/importConnectionSource/).xml) and Power Platform ToolBox (restricts picker to.json)ConnectionsList.xmlpathmodalBridge)connectionManagement.tsimportConnections()now opens the source modal first, then opens a format-restricted file picker — no more.xml/.jsonauto-detection heuristicselectConnectionandeditConnectionmodalsUse a meaningful title for the pull request.
Follow the guidelines from the CONTRIBUTING.md.
Test the change in your own code. (Compile and run)
Resolve all GH Copilot comments.