Adds Filter switch #110
Merged
Adds Filter switch #110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Tyler James Leonhardt <tylerl0706@gmail.com>
| LoadData(); | ||
| AddRows(win); | ||
|
|
||
| _filterField.Text = _applicationData.Filter; |
Member
There was a problem hiding this comment.
To make the code more robust, you should handle when Filter is null here instead of setting the default value to empty string in the other file for Filter.
You can do a simple:
_applicationData.Filter ?? string.EmptyAnd then remove the default value in the cmdlet
| public string Title { get; set; } | ||
| public OutputModeOption OutputMode { get; set; } | ||
| public bool PassThru { get; set; } | ||
| public string Filter { get;set; } |
Member
There was a problem hiding this comment.
Suggested change
| public string Filter { get;set; } | |
| public string Filter { get; set; } |
| AddRows(win); | ||
|
|
||
| _filterField.Text = _applicationData.Filter; | ||
| _filterField.CursorPosition = _applicationData.Filter.Length; |
Member
There was a problem hiding this comment.
Then use
Suggested change
| _filterField.CursorPosition = _applicationData.Filter.Length; | |
| _filterField.CursorPosition = _filterField.Text.Length; |
Collaborator
Author
|
Good feedback. Thanks. Should be good to go now. |
Member
|
@tig can you also update the markdown doc for ocgv? |
Member
|
You may want to run that BuildCmdletHelp task locally to debug the CI issue. Looks like you have a missing heading or something. |
Member
|
Last thing, I promise. If you rev the version in the psd1 to 0.6.0 and add a section in the psd1 changelog, I can merge this in and snap a release :) |
Collaborator
Author
|
Wha? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR address #109 by adding a
-Filterswitch toocgv.