-
Notifications
You must be signed in to change notification settings - Fork 68
move to compliance repo #128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move to compliance repo #128
Conversation
| 'publish/OutGridView.Models.pdb' | ||
| 'Microsoft.PowerShell.OutGridView.Models' = @( | ||
| 'publish/Microsoft.PowerShell.OutGridView.Models.dll', | ||
| 'publish/Microsoft.PowerShell.OutGridView.Models.pdb' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you publish the PDB too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah... why not? :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not the nuget standard
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For information.
From https://devblogs.microsoft.com/dotnet/producing-packages-with-source-link/
Source Link is easy to add to your projects and we highly recommend that all projects configure it by default.
|
@TravisEz13 @adityapatwardhan I've moved to the new syntax. Please rereview. |
| vmImage: 'vs2017-win2016' | ||
| steps: | ||
| - template: templates/ci-general.yml | ||
| - job: 'SignBuild' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to run component governance here or upload assets.json file from here and download them in compliance stage.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
|
please rereview @adityapatwardhan |
|
Merging this in now but it might be worth having a discussion around pdbs with the team. Most things I worked on shipped pdbs with it. |
* move to compliance repo * first attempt at release * add stages * move pool * remove pkges task * add variable group * try copying files * remove extra extract * copy to signed dir * change tsa name * move to PowerShell@2 * use new syntax * change path * idk * idk * move to publish task * try these agents * ConsoleGuiTools asset.json * try different directory * stuff * publish artifacts
No description provided.