Skip to content

Conversation

@TylerLeonhardt
Copy link
Member

No description provided.

'publish/OutGridView.Models.pdb'
'Microsoft.PowerShell.OutGridView.Models' = @(
'publish/Microsoft.PowerShell.OutGridView.Models.dll',
'publish/Microsoft.PowerShell.OutGridView.Models.pdb'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you publish the PDB too?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah... why not? :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not the nuget standard

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For information.
From https://devblogs.microsoft.com/dotnet/producing-packages-with-source-link/

Source Link is easy to add to your projects and we highly recommend that all projects configure it by default.

@TylerLeonhardt
Copy link
Member Author

@TravisEz13 @adityapatwardhan I've moved to the new syntax. Please rereview.

vmImage: 'vs2017-win2016'
steps:
- template: templates/ci-general.yml
- job: 'SignBuild'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to run component governance here or upload assets.json file from here and download them in compliance stage.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@TylerLeonhardt
Copy link
Member Author

please rereview @adityapatwardhan

@TylerLeonhardt
Copy link
Member Author

Merging this in now but it might be worth having a discussion around pdbs with the team. Most things I worked on shipped pdbs with it.

@TylerLeonhardt TylerLeonhardt merged commit 6aa62cd into PowerShell:master Dec 21, 2020
tig pushed a commit to tig/GraphicalTools that referenced this pull request Apr 27, 2021
* move to compliance repo

* first attempt at release

* add stages

* move pool

* remove pkges task

* add variable group

* try copying files

* remove extra extract

* copy to signed dir

* change tsa name

* move to PowerShell@2

* use new syntax

* change path

* idk

* idk

* move to publish task

* try these agents

* ConsoleGuiTools asset.json

* try different directory

* stuff

* publish artifacts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants