Fix local use of msrustup#1456
Merged
andyleejordan merged 3 commits intoPowerShell:mainfrom Apr 1, 2026
Merged
Conversation
andyleejordan
changed the title
msrustup
andyleejordan
force-pushed
the
ignore-msrustup
branch
2 times, most recently
from
5446306 to
937c512
Compare
The ADO pipeline was working as expected, but local builds were behaving differently because of some old incorrect logic.
This is confirmed fixed in 1.94+. I tested ms-beta which is 1.95, Mikey tested public 1.94. However, even with ms-prod-1.93-20260401 (today's release), this fails compilation (due to warning being treated as error). More unfortunately, the ignore must be at the file-level due to how the macro expands. I tested both on the field-level and enum-level, to no avail.
andyleejordan
force-pushed
the
ignore-msrustup
branch
from
937c512 to
9c20450
Compare
michaeltlombardi
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In several
!$useADOconditions, we were unfortunately not actually setting the specified Rust channel to use, and instead reverting back todefault. This meant that e.g. Mikey was building with 1.94, while I was building with 1.93 (having manually set my toolchain).