Fix adding what-if capability to resources#1502
Open
SteveL-MSFT wants to merge 3 commits intoPowerShell:mainfrom
Open
Fix adding what-if capability to resources#1502SteveL-MSFT wants to merge 3 commits intoPowerShell:mainfrom
what-if capability to resources#1502SteveL-MSFT wants to merge 3 commits intoPowerShell:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes resource capability detection so dsc resource list correctly reports the whatIf capability when a resource supports what-if mode via either the newer whatIfArg mechanism on set/delete or the legacy whatIf operation.
Changes:
- Detect
whatIfcapability fromset.args/delete.argscontainingwhatIfArg, and from the legacywhatIfoperation in the manifest. - Switch capability accumulation in discovery from
VectoHashSetto avoid duplicates. - Add/extend tests and update the table capability legend to include
wfor what-if.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| lib/dsc-lib/src/dscresources/dscresource.rs | Makes Capability hashable/equatable to support set-based capability accumulation. |
| lib/dsc-lib/src/discovery/command_discovery.rs | Implements the updated what-if capability detection logic while parsing manifests. |
| dsc/tests/dsc_resource_list.tests.ps1 | Adds a Pester test intended to validate what-if capability reporting in dsc resource list. |
| dsc/src/subcommand.rs | Updates table capability display mapping to include WhatIf as w. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
There's 2 ways to detect if a resource supports
what-if:setordeletehas thewhatIfArgargwhatIfoperationChanged the code from using a
Vecto using aHashSetto avoid having to check ifwhat-ifwas already added to capabiltiies.PR Context
Fix #1501