Change PSScript resource to not exit on non-terminating errors#1554
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the PSScript resource behavior so non-terminating PowerShell errors no longer fail resource execution, addressing issue #1547 by warning while continuing.
Changes:
- Replaces the hard failure on
$ps.HadErrorswith a warning trace. - Adds a regression test for non-terminating errors continuing execution and preserving output.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
resources/PSScript/psscript.ps1 |
Changes HadErrors handling from exit-on-error to warn-and-continue. |
resources/PSScript/psscript.tests.ps1 |
Adds test coverage for non-terminating errors during get. |
Co-authored-by: Mikey Lombardi (He/Him) <michael.t.lombardi@gmail.com>
michaeltlombardi
approved these changes
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
The PSScript resource was too strict in that
HadErrorssimply means that$Errorhad errors in it including non-terminating (like SilentlyContinue) errors. Change is to emit a warning message but continue.PR Context
Fix #1547