Add v1 code back by ayousuf23 · Pull Request #139 · PowerShell/Microsoft.PowerShell.Archive

ayousuf23 · 2022-08-11T20:54:20Z

PR Summary

This PR adds back the v1 code, tests, build scripts, and yaml files to the Archive_v1 folder. It updates the required PowerShell version for the v2.0.1 module to PowerShell v7.3.0

PR Context

See above.

…onPath's extension

…estinationPath's extension

…added support for tar, added support for overwrite

…preserved, fixed bug where error and warning messages were not being shown

…d psd1 file

… merging branches

… based on feedback

…ges.Designer.cs and to remove debug symbols in Release config

…hiveFactory.TryGetArchiveFormatFromExtension, added another list to keep track of paths from -LiteralPath and -Path seperately

…n when installing Pester in tests script, removed default valuesm in parameter attributes, and other minor changes

…r formatting changes

…g changes

…me is not necessarily equal to FileSystemInfo.Name

…r than collecting all paths first

… testing invalid paths

…e CI status, fixed a bug where a path is determined to be relative to the working directory if the working directory is on a different drive than the path

ayousuf23 · 2022-08-11T21:05:54Z

/azp run PowerShell.Microsoft.PowerShell.Archive

azure-pipelines · 2022-08-11T21:05:59Z

Pull request contains merge conflicts.

daxian-dbw · 2022-08-11T21:08:30Z

@ayousuf23 Thanks for getting to this promptly!
Can you please add the build scripts and ymal files related to v1 to the Archive_v1 folder as well?

ayousuf23 · 2022-08-11T21:10:52Z

@daxian-dbw Sure, I'll add those as well

…ll.Archive into preview1-pr

ayousuf23 · 2022-08-11T21:17:22Z

@daxian-dbw I added the build scripts and yaml files. I'm waiting for the tests to run and then it can be merged.

daxian-dbw

LGTM

ayousuf23 · 2022-08-11T21:22:05Z

@daxian-dbw The tests passed. You can merge it now

ayousuf23 · 2022-08-11T21:22:27Z

I don't have permission to merge.

daxian-dbw · 2022-08-11T21:27:08Z

I don't have permission to merge.

Me neither 😄. @SteveL-MSFT can you please merge?

iSazonov · 2022-08-12T03:29:58Z

Why not preserve a clean history and create new repository PowerShell/Microsoft.PowerShell.Archive.V2?

SeeminglyScience · 2022-08-12T17:15:32Z

Talked this over with everyone and we're gonna go with creating a branch off the old code in case it's needed for servicing.

SeeminglyScience · 2022-08-12T17:32:36Z

FYI servicing

daxian-dbw · 2022-08-12T20:42:13Z

src/Microsoft.PowerShell.Archive.psd1

 Copyright = '(c) Microsoft. All rights reserved.'
 Description = 'PowerShell module for creating and expanding archives.'
-PowerShellVersion = '7.2.5'
+PowerShellVersion = '7.3.0'


@ayousuf23 Please open a new PR for this version change.

t-ayousuf and others added 30 commits July 12, 2022 11:02

Add .gitattributes, .gitignore, and README.md.

7711837

Add project files.

7512b08

added path helper, archive entry

aff9728

updated path helper

e535995

resolved bug where GetEntryName was throwing an ArgumentException

04adc0b

fixed a bug, started work on zip support

915f344

worked on zip archive support

c05e063

added ArchiveFactory class

ef66ef9

imporved zip support

dde4deb

fixed a bug in tests, added error handling for DestinationPath

fcde5dd

fixed bug in tests where Test-ZipArchive was not working correctly

636444d

added tests for DestinationPath

50e0da3

added additional tests, added TODOs

5cede7e

updated tests

88ea929

added resx files for messages, refactored code, updated structure, etc.

3dffd1d

refactored PathHelper class

63490c6

worked on automatically determining archive format based on Destinati…

7986a1e

…onPath's extension

added support for determining archive format automatically based on D…

e062f64

…estinationPath's extension

fixed a bug with archive format warning, added TarArchive file

8fd551e

renamed Action to WriteMode, fixed bug with compressing directories, …

d872cf8

…added support for tar, added support for overwrite

fixed bug where the directory structure of directories was not being …

bc49871

…preserved, fixed bug where error and warning messages were not being shown

addded exception handling to PathHelper class

6ee7ccb

removed files from git, removed tar support for preview release, adde…

3fc29de

…d psd1 file

updated build script, updated exception handling in PathHelper

bf53c33

used FileSystemInfo instead of String to store full path information

5b355a6

updated checking for the same source path and destination path

615994b

updated build configuration

33d863d

merged tests branch with CI branch

29be220

updated project version with prelease info, removed tar support after…

fd9b327

… merging branches

updated CI config, fixed bug with missing error message, fixed tests

cb98554

ayousuf23 added 12 commits July 28, 2022 17:31

used pascal case for ArchiveFormat enum members, refactored some code…

03ce64a

… based on feedback

fixed formatting for multiple files, updated csproj to generate Messa…

d9c0e8e

…ges.Designer.cs and to remove debug symbols in Release config

fixed missing quotation mark in CI config, updated switch code in Arc…

d384f50

…hiveFactory.TryGetArchiveFormatFromExtension, added another list to keep track of paths from -LiteralPath and -Path seperately

added assertions to prevent possible null error, added RequiredVersio…

3ae0355

…n when installing Pester in tests script, removed default valuesm in parameter attributes, and other minor changes

added localized messages for Add, Create, and progress bar text, mino…

abeb7a2

…r formatting changes

added copyright header, removed usage of DS in tests, minor formattin…

8373aca

…g changes

updated .gitignore, added explanation for why ArchiveAddition.EntryNa…

f7c2af4

…me is not necessarily equal to FileSystemInfo.Name

updated Compress-Archive cmdlet to resolve a path one at a time rathe…

f7cdfd2

…r than collecting all paths first

fixed a bug where PathNotFound error was not thrown, fixed a bug when…

b5e23c2

… testing invalid paths

added custom assertions for testing zip archives

fcaaa8e

updated CI to run tests using new assertion, updated README with Azur…

dc557a5

…e CI status, fixed a bug where a path is determined to be relative to the working directory if the working directory is on a different drive than the path

updated module version, added v1 archive module code and tests

3480150

ayousuf23 changed the title ~~Preview1 pr~~ Add v1 code back Aug 11, 2022

Merge branch 'master' into preview1-pr

aa1a5e2

ayousuf23 added 2 commits August 11, 2022 14:16

added v1 build scripts and yaml files

22a23fa

Merge branch 'preview1-pr' of github.com:ayousuf23/Microsoft.PowerShe…

8d168d2

…ll.Archive into preview1-pr

daxian-dbw approved these changes Aug 11, 2022

View reviewed changes

SeeminglyScience closed this Aug 12, 2022

daxian-dbw reviewed Aug 12, 2022

View reviewed changes

Conversation

ayousuf23 commented Aug 11, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Summary

PR Context

Uh oh!

ayousuf23 commented Aug 11, 2022

Uh oh!

azure-pipelines bot commented Aug 11, 2022

Uh oh!

daxian-dbw commented Aug 11, 2022

Uh oh!

ayousuf23 commented Aug 11, 2022

Uh oh!

ayousuf23 commented Aug 11, 2022

Uh oh!

daxian-dbw left a comment

Choose a reason for hiding this comment

Uh oh!

ayousuf23 commented Aug 11, 2022

Uh oh!

ayousuf23 commented Aug 11, 2022

Uh oh!

daxian-dbw commented Aug 11, 2022

Uh oh!

iSazonov commented Aug 12, 2022

Uh oh!

SeeminglyScience commented Aug 12, 2022

Uh oh!

SeeminglyScience commented Aug 12, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

daxian-dbw Aug 12, 2022

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

ayousuf23 commented Aug 11, 2022 •

edited

Loading

SeeminglyScience commented Aug 12, 2022 •

edited

Loading