This repository was archived by the owner on Dec 8, 2021. It is now read-only.
New extension design#3
Merged
SteveL-MSFT merged 33 commits intoPowerShell:masterfrom Nov 14, 2019
PaulHigin:new-extension-design
Merged
New extension design#3SteveL-MSFT merged 33 commits intoPowerShell:masterfrom PaulHigin:new-extension-design
SteveL-MSFT merged 33 commits intoPowerShell:masterfrom
PaulHigin:new-extension-design
Conversation
SteveL-MSFT
suggested changes
Nov 11, 2019
Member
SteveL-MSFT
left a comment
SteveL-MSFT
left a comment
There was a problem hiding this comment.
GitHub
says "Modules/Microsoft.PowerShell.SecretsManagement/TestExtensionModules/TestLocalScript/TestLocalScript.psm1" is a binary file. Is this file saved as UTF-8 NoBOM? I suggest you schedule a design review and then we should go through a more thorough code review after that.
...ll.SecretsManagement/TestExtensionModules/AKVault/build/AKVaultExtension/AKVaultExtension.cs
Outdated
Show resolved
Hide resolved
Modules/Microsoft.PowerShell.SecretsManagement/scripts/Install-SecretsManagement.ps1
Outdated
Show resolved
Hide resolved
…-SecretsManagement.ps1 Co-Authored-By: Steve Lee <slee@microsoft.com>
…odules into new-extension-design
Member
|
Now it says Modules/Microsoft.PowerShell.SecretsManagement/TestExtensionModules/AKVaultScript/AKVaultScript.psm1 is a binary file |
SteveL-MSFT
approved these changes
Nov 14, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the sum total of multiple commits for Secrets Management, using the new C# abstract class vault extension mechanism. Vault extension is based on PowerShell modules. One method is a PowerShell module with a RequiredAssembly having the C# class type implementation, and the other is a script module that implements required extension methods as script functions.