This repository was archived by the owner on Dec 8, 2021. It is now read-only.
Numerous changes Secrets Management to address review feedback#53
Merged
PaulHigin merged 5 commits intoPowerShell:masterfrom Mar 2, 2020
Merged
Numerous changes Secrets Management to address review feedback#53PaulHigin merged 5 commits intoPowerShell:masterfrom
PaulHigin merged 5 commits intoPowerShell:masterfrom
Conversation
SteveL-MSFT
suggested changes
Feb 28, 2020
.../TestExtensionModules/AKVaultScript/SecretManagementExtension/SecretManagementExtension.psm1
Show resolved
Hide resolved
Modules/Microsoft.PowerShell.SecretsManagement/src/code/SecretsManagement.cs
Outdated
Show resolved
Hide resolved
Modules/Microsoft.PowerShell.SecretsManagement/src/code/Utils.cs
Outdated
Show resolved
Hide resolved
Contributor
Author
|
I am going to merge these changes before renaming the module. Renaming the module is going to be a big change, affecting CI, tests, etc., and I'll do that in a separate PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SecretInformationto return for Get-SecretInfo.vaultNameto all vault extension functions.additionalParametersparameter in SecretManagementExtension abstract classes.ps:SecretNameNote that many of these changes are breaking, and requires a complete replacement of Secrets Management module and any extension modules. Also any existing built in local vault secret can no longer be retrieved and must be re-saved.