Skip to content
This repository was archived by the owner on Dec 8, 2021. It is now read-only.

Numerous changes Secrets Management to address review feedback#53

Merged
PaulHigin merged 5 commits intoPowerShell:masterfrom
PaulHigin:update-review-feedback
Mar 2, 2020
Merged

Numerous changes Secrets Management to address review feedback#53
PaulHigin merged 5 commits intoPowerShell:masterfrom
PaulHigin:update-review-feedback

Conversation

@PaulHigin
Copy link
Contributor

@PaulHigin PaulHigin commented Feb 28, 2020

  1. Create public SecretInformation to return for Get-SecretInfo.
  2. Add vaultName to all vault extension functions.
  3. Fix additionalParameters parameter in SecretManagementExtension abstract classes.
  4. Add Test-Vault cmdlet, and new required extension vault TestVault() to abstract class.
  5. Rename cmdlets and public types to remove 'secrets' plurality (except for Microsoft.PowerShell.SecretsManagement).
  6. Change CredMan naming prefix to ps:SecretName
  7. Fix return byte[] bug in example test script extension.
  8. Update tests.

Note that many of these changes are breaking, and requires a complete replacement of Secrets Management module and any extension modules. Also any existing built in local vault secret can no longer be retrieved and must be re-saved.

@PaulHigin PaulHigin self-assigned this Feb 28, 2020
@PaulHigin
Copy link
Contributor Author

I am going to merge these changes before renaming the module. Renaming the module is going to be a big change, affecting CI, tests, etc., and I'll do that in a separate PR.

@PaulHigin PaulHigin merged commit 982d69e into PowerShell:master Mar 2, 2020
@PaulHigin PaulHigin deleted the update-review-feedback branch March 2, 2020 18:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants