Skip to content

Bug fix for parsing required modules when publishing#1326

Merged
alerickson merged 9 commits intoPowerShell:masterfrom
alerickson:publishModSpecBug
Aug 3, 2023
Merged

Bug fix for parsing required modules when publishing#1326
alerickson merged 9 commits intoPowerShell:masterfrom
alerickson:publishModSpecBug

Conversation

@alerickson
Copy link
Copy Markdown
Member

PR Summary

RequiredModules were not being parsed correctly from a module manifest during publish time, thus when, for example, RequiredModules contained both a Hashtable and a string, the hashtable would be parsed as a string and incorrectly assume the module name was "System.Collections.Hashtable". This PR loops through every element of RequiredModules and tries to parse each object individually instead of assuming that all types within RequiredModules are the same and attempting to parse the object as a whole.

PR Context

Resolves #1305

PR Checklist

Comment thread src/code/PublishPSResource.cs Outdated
Comment thread src/code/PublishPSResource.cs Outdated
@alerickson alerickson merged commit 7f9d65e into PowerShell:master Aug 3, 2023
@alerickson alerickson deleted the publishModSpecBug branch August 3, 2023 23:44
@SydneyhSmith SydneyhSmith added PR-Bug This pull request resolves an issue bug Release This pull request is part the next release labels Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR-Bug This pull request resolves an issue bug Release This pull request is part the next release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Publish-PSResource fails with ModuleSpecification and prerelease module

3 participants