Bug fix for parsing required modules when publishing#1326
Merged
alerickson merged 9 commits intoPowerShell:masterfrom Aug 3, 2023
alerickson:publishModSpecBug
Merged
Bug fix for parsing required modules when publishing#1326alerickson merged 9 commits intoPowerShell:masterfrom alerickson:publishModSpecBug
alerickson merged 9 commits intoPowerShell:masterfrom
alerickson:publishModSpecBug
Conversation
adityapatwardhan
requested changes
Aug 2, 2023
adityapatwardhan
approved these changes
Aug 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
RequiredModules were not being parsed correctly from a module manifest during publish time, thus when, for example, RequiredModules contained both a Hashtable and a string, the hashtable would be parsed as a string and incorrectly assume the module name was "System.Collections.Hashtable". This PR loops through every element of RequiredModules and tries to parse each object individually instead of assuming that all types within RequiredModules are the same and attempting to parse the object as a whole.
PR Context
Resolves #1305
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.