fix(repository:) Add input validation for GetOperation#2002
Open
Gijsreyn wants to merge 2 commits into
Open
Conversation
GetOperationGetOperation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds explicit handling for resource get when no --input/stdin is provided, preventing PowerShell parameter-binding errors and returning a clean non-zero exit code.
Changes:
- Add an early validation in
GetOperationto fail fast when no input is provided. - Add a CI test ensuring
resource getwithout--inputexits non-zero and avoids an unhandled exception.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| test/DscResource/PSResourceGetDSCResource.Tests.ps1 | Adds a regression test for resource get without input to ensure clean failure behavior. |
| src/dsc/psresourceget.ps1 | Adds a guard clause to reject missing stdin/--input before attempting JSON parsing. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
This pull request adds a simple input validation when it's empty for the
GetOperationon theRepositoryresource.PR Context
When
--inputis omitted, DSC closes the child process stdin without writing anything. Theresource manifest uses
"input": "stdin"and invokes the script as$Input | ./psresourceget.ps1 ..., so$Inputis an empty enumerator and the$stdinputpipeline parameter is never bound (keeping it $null).Fixes #2001
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.