Download, install, and delete pwsh dist in the same layer to reduce final image size (RedHat family-only)#207
Merged
TravisEz13 merged 4 commits intoPowerShell:masterfrom Apr 11, 2019
claudeleveille:download-pwsh-properly
Merged
Download, install, and delete pwsh dist in the same layer to reduce final image size (RedHat family-only)#207TravisEz13 merged 4 commits intoPowerShell:masterfrom claudeleveille:download-pwsh-properly
TravisEz13 merged 4 commits intoPowerShell:masterfrom
claudeleveille:download-pwsh-properly
Conversation
added 4 commits
April 10, 2019 00:02
|
|
TravisEz13
approved these changes
Apr 10, 2019
Member
|
@PoshChan Please remind me in 11 hours |
Member
|
Leaving PR open for review for the minimum 24 hours |
Collaborator
|
@TravisEz13, will remind you in 11 hours |
Member
|
We are close enough |
Collaborator
|
@TravisEz13, this is the reminder you requested 11 hours ago |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
This patch uses the included curl on RedHat-based distro images to download PowerShell in the same layer it's installed in. This slices off one layer from the resulting images and saves ~50 MB (the size of the PowerShell dist package) on final image size.
PR Checklist
Dockerfile,.sh,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.