Skip to content

Conversation

@DanielSSilva
Copy link
Contributor

@DanielSSilva DanielSSilva commented May 9, 2019

Updated Dockerfile to the latest release

PR Summary

PR Checklist

Updated Dockerfile to the latest release
Copy link
Member

@TravisEz13 TravisEz13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are not currently building this image

@DanielSSilva
Copy link
Contributor Author

Right. I just followed the same PR logic done here #121
Although it's not currently being built, shouldn't it be good to keep up to date?

Copy link
Collaborator

@RDIL RDIL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should hold off merging this until the image builds resume.

@ghost ghost added the Waiting on Author label May 9, 2019
@TravisEz13
Copy link
Member

This isn't about image build resuming. No one has ever integrated this image into the build system.

@RDIL
Copy link
Collaborator

RDIL commented May 9, 2019

Then... remove it?

@DanielSSilva
Copy link
Contributor Author

Well, I'm sorry for the confusion then. Maybe it's better to close it

@TravisEz13
Copy link
Member

TravisEz13 commented May 9, 2019

@RDIL Please file an issue to add the image to the build system.
@DanielSSilva No, we should consider the change. It is simple enough, the change only changes an argument, not the logic of the code.

@TravisEz13
Copy link
Member

@PoshChan Please remind me in 24 hours.

@PoshChan
Copy link
Collaborator

PoshChan commented May 9, 2019

@TravisEz13, will remind you in 24 hours.

@ghost
Copy link

ghost commented May 10, 2019

Hello @TravisEz13!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull-requests of this repository that have been opened for at least 24 hours, a condition that is not currently met. No worries though, I will be back when the time is right! 😉

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me and give me an instruction to get started! Learn more here.

@ghost ghost merged commit db457e3 into PowerShell:master May 10, 2019
@PoshChan
Copy link
Collaborator

@TravisEz13, this is the reminder you requested 24 hours. ago

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants