Skip to content

Conversation

@SteveL-MSFT
Copy link
Member

No description provided.

@SteveL-MSFT SteveL-MSFT force-pushed the expermental-feature-user-experience branch from d29ac44 to 2360f5f Compare November 3, 2018 05:31
@joeyaiello
Copy link
Contributor

joeyaiello commented Nov 26, 2018

Notes from our discussion with the @PowerShell/powershell-committee today:

  • Everyone's on board with the -ListAvailable breaking change
    • Default Get-ExperimentalFeature might also want to expose what's present in the existing config file (e.g. if an experimental feature previously enable is no longer available)
    • Overall open issue: cleanup of the config flies should be solved.
  • Experimental features do not currently respect the CurrentUser config file because there aren't yet version-specific user scope powershell.config.json files
  • Despite that, we agree that CurrentUser should be the default for Enable-/Disable-ExperimentalFeature. First step is to just allow them to work regardless of version. Later, we can enable version-specific configs.
  • Open issue: how do we deal with "pending" or "unavailable" experimental features?
    • In the future, we can add something like RebootRequired property, or replace the Enabled property returned by Get-ExperimentalFeature with something like State that can include more complicated pending/unavailable states.
    • Of that, we should change the boolean in Enabled to an enum in State today.
    • We didn't want to block this RFC on this issue, as this immediately unblocks the usage of experimental features.

@joeyaiello joeyaiello closed this Nov 26, 2018
@joeyaiello joeyaiello reopened this Nov 26, 2018
@joeyaiello
Copy link
Contributor

We'll wait until 12/1 to accept this formally and merge the PR at PowerShell/PowerShell#8318

@iSazonov
Copy link
Contributor

If we get a list of available experimental features from the engine, then we don’t have to worry about what’s "stale" in the config - it will be available only for preview versions (write a warning are enough). Also we don’t have to worry about breaking changes in Enable-/Disable-ExperimentalFeature cmdlet for the same reason. Not having CurrentUser config is not critical for the same reason.

@SteveL-MSFT
Copy link
Member Author

@PowerShell/powershell-committee reviewed this and agreed to approve.

Steve Lee: Approve
Jim Truher: Approve
Dongbo Wang: Approve
Hemant Mahawar : Approve
Joey Aiello: Not Present
Bruce Payette: Not Present
Kenneth Hansen: Not Present

@SteveL-MSFT SteveL-MSFT merged commit 27894a4 into PowerShell:master Dec 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants