Fix segfault when running snap on Ubuntu 18.04 by moving to core18#38
Fix segfault when running snap on Ubuntu 18.04 by moving to core18#38TravisEz13 merged 3 commits intoPowerShell:masterfrom
Conversation
TravisEz13
force-pushed
the
Move_to_core18
branch
11 times, most recently
from
2581121 to
67ef623
Compare
| @@ -2,18 +2,8 @@ name: powershell-preview | |||
|
|
|||
There was a problem hiding this comment.
This is the fix to resolve the seg fault. Other changes are to support building these changes
There was a problem hiding this comment.
Would you be able to give some more information about what was causing the segfault previously and how/where these changes prevent it now?
There was a problem hiding this comment.
Can you explain what the fix is? Is it including the additional libraries?
There was a problem hiding this comment.
To document:
- We were originally building snaps with older dependencies, but dotnet inside the snap would resolve the newest it could find on the machine, breaking snaps on systems with newer inbox versions of things like libicu
- .NET don't see this as their problem since (1) their main scenario is being the only app on the box and (2) even if they're not, they're probably expecting to be a non-classic snap
- To fix this, we now build with newer (newest?) versions of those dependencies, which is something that the snap model is essentially intended for
- However, to make this fix happen, @TravisEz13 had to do work to build the images to assemble the snap with the new dependencies, so it was more work than a simple config addition
I do think we should take this back to .NET -- it strikes me as a fairly serious issue if we fall under their support aegis, since it breaks the only reason to have a snap
TravisEz13
changed the title
TravisEz13
force-pushed
the
Move_to_core18
branch
from
67ef623 to
42414d7
Compare
| @@ -2,18 +2,8 @@ name: powershell-preview | |||
|
|
|||
There was a problem hiding this comment.
Would you be able to give some more information about what was causing the segfault previously and how/where these changes prevent it now?
| echo "Done building third party notices file - $thirdPartyNoticeFile" | ||
| stage-packages: | ||
| - libicu55 | ||
| - libicu60 |
There was a problem hiding this comment.
I assume this is the real fix here, compiling for the newest libicu version to avoid .NET Core picking the wrong one up from elsewhere?
There was a problem hiding this comment.
The problem was that .NET Core picks individual DLLs' newest to oldest, and it can see into the OS. so on 18.04 it ends up picking a mix of old and new which don't work together.
3 participants
No description provided.