This repository was archived by the owner on Feb 13, 2025. It is now read-only.
Add usr/lib to rpath to fix segfaults
#42
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TravisEz13
commented
Oct 31, 2019
This reverts commit 349026c. # Conflicts: # stable/snap/snapcraft.yaml
adityapatwardhan
approved these changes
Nov 1, 2019
rjmholt
approved these changes
Nov 1, 2019
stable/launcher/powershell-wrapper
Outdated
| [ -n "$XDG_RUNTIME_DIR" ] && mkdir -p $XDG_RUNTIME_DIR -m 700 | ||
|
|
||
| # make sure DOTNET loads the ICU that we ship | ||
| export CLR_ICU_VERSION_OVERRIDE=60.2 |
There was a problem hiding this comment.
Does this need to be exported?
It might be better to set the env var with the exec, like this?
Member
Author
There was a problem hiding this comment.
This script is already being exec'ed. It seems redundant.
Member
Author
There was a problem hiding this comment.
But found there is a YAML syntax to put it in that exec... Moving it there.
TravisEz13
force-pushed
the
fix_libicu
branch
from
298fc1e to
bc57fd8
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
usr/libto rpath to fix segfaultsAlso, set
CLR_ICU_VERSION_OVERRIDEto60.2so that DotNet doesn't try to load any other.fixes #33