Skip to content
This repository was archived by the owner on Feb 13, 2025. It is now read-only.

Conversation

@anamnavi
Copy link
Member

@anamnavi anamnavi commented Aug 15, 2022

PR Summary

Upgrade from base:core18 to base:core20, and provide security patches for the libraries that are bundled in the Snap Package that PowerShell is relying upon and minimalize install size.

PR Context

Resolves #87


adopt-info: powershell
base: core18
base: core20

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned in https://github.com/PowerShell/PowerShell-Snap/issues/87#issuecomment-1216799996 it might be advisable to skip core20 and jump directly to core22.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the thorough explanation of the benefits of upgrading to core22. I'll discuss this with the team.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The guidance we've received is that core20 is the recommended version right now as it the most stable release. We'll update to core20 first and then can evaluate core22 as needed.


adopt-info: powershell-preview
base: core18
base: core20

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned in https://github.com/PowerShell/PowerShell-Snap/issues/87#issuecomment-1216799996 it might be advisable to skip core20 and jump directly to core22.


adopt-info: powershell
base: core18
base: core20

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned in https://github.com/PowerShell/PowerShell-Snap/issues/87#issuecomment-1216799996 it might be advisable to skip core20 and jump directly to core22.

@anamnavi anamnavi requested a review from TravisEz13 August 16, 2022 16:57
@TravisEz13
Copy link
Member

Let's merge this into a new branch and create a test channel before we try to release this.

@TravisEz13 TravisEz13 changed the base branch from master to updateCore August 16, 2022 18:06
@xnox
Copy link

xnox commented Aug 16, 2022

Imho, it is easier to step bases one at a time; land core18 -> core20 (into a test channel) then do another core20 -> core22 if everything is working as expected.

@anamnavi anamnavi merged commit b263ee1 into PowerShell:updateCore Aug 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Please upgrade to base: core20

4 participants